Skip to content

[Security Solution] Expanded flyout Entities Overview#154196

Merged
christineweng merged 9 commits intoelastic:mainfrom
christineweng:flyout-entity-overview
Apr 6, 2023
Merged

[Security Solution] Expanded flyout Entities Overview#154196
christineweng merged 9 commits intoelastic:mainfrom
christineweng:flyout-entity-overview

Conversation

@christineweng
Copy link
Copy Markdown
Contributor

@christineweng christineweng commented Mar 31, 2023 •
edited
Loading

Summary

This PR adds additional features to the expandable flyout:

  • Entities overview in the expandable flyout -> right panel -> insights that includes:
    • Host IP addresses and risk level (with license)
    • User IP addresses and risk level (with license)
    • Navigation to view more details in the left panel -> insights -> entities tab
  • Added sections under Insights in the expandable flyout -> left panel -> insights

image

How to test

  • add xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled'] to the kibana.dev.json file
  • go to the Alerts page, and click on the expand detail button on any row of the table
  • click on Overview, then Insights

https://github.com/elastic/security-team/issues/6071

Checklist

@christineweng christineweng self-assigned this Mar 31, 2023
@christineweng christineweng added backport:skip This PR does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.8.0 labels Mar 31, 2023
@christineweng christineweng force-pushed the flyout-entity-overview branch from 8860af8 to 9c7e4dd Compare March 31, 2023 21:48
@christineweng christineweng force-pushed the flyout-entity-overview branch from 9c7e4dd to e6861da Compare March 31, 2023 22:08
@christineweng christineweng marked this pull request as ready for review April 3, 2023 13:22
@christineweng christineweng requested review from a team as code owners April 3, 2023 13:22
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 3, 2023

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 3, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@christineweng christineweng added release_note:skip Skip the PR/issue when compiling release notes release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 3, 2023
PhilippeOberti
PhilippeOberti requested changes Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! Pulled down the branch and everything works as expected in the UI. I left a few comments, some of them I'm glad to discuss and ignore if we want to!

@PhilippeOberti PhilippeOberti changed the title [Security Solution] Expanded fly out Entities Overview [Security Solution] Expanded flyout Entities Overview Apr 4, 2023
@christineweng christineweng requested review from a team as code owners April 5, 2023 21:12
@christineweng christineweng removed request for a team and ashokaditya April 5, 2023 21:14
PhilippeOberti
PhilippeOberti approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome job @christineweng , thanks for making all the changes!

I'm pushing a commit to make some super minor changes, let me know if you don't like them I'll revert them 😄

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 6, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / dashboard app - group 1 Changing field formatter to Url applied on dashboard
  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3808 3818 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.8MB 15.9MB +42.5KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @christineweng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees

@christineweng christineweng

Labels

backport:skip This PR does not require backporting release_note:feature Makes this part of the condensed release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christineweng @elasticmachine @kibana-ci @PhilippeOberti