Skip to content

[SharedUx/POC] New package for project-style navigation. Integration from Serverless Search POC#153508

Closed
tsullivan wants to merge 6 commits intoelastic:mainfrom
tsullivan:serverless/poc/unified_shared_ux_navigation
Closed

[SharedUx/POC] New package for project-style navigation. Integration from Serverless Search POC#153508
tsullivan wants to merge 6 commits intoelastic:mainfrom
tsullivan:serverless/poc/unified_shared_ux_navigation

Conversation

@tsullivan
Copy link
Copy Markdown
Member

@tsullivan tsullivan commented Mar 22, 2023 •
edited
Loading

POC ONLY: NOT FOR MERGE

Summary

This PR adds a custom project side nav to the Search Serverless plugin.

Other changes

Changes in packages/core/chrome/core-chrome

  • Adds setProjectNavigation to ChromeStart
  • Passes the navigation element to the project header
  • Undo dark background for the side nav

Changes in x-pack/plugins/serverless/public

  • Adds setServerlessNavigation to ServerlessPluginStart

Screencast

Screen.Recording.2023-04-27.at.11.08.24.AM.mov

@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 3 times, most recently from 5ec4f95 to 5a5d7fd Compare March 23, 2023 00:29
@tsullivan tsullivan mentioned this pull request Mar 23, 2023
Closed
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented Mar 23, 2023

cc @semd @MichaelMarcialis

@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 3 times, most recently from 5d166bf to b436496 Compare March 31, 2023 16:43
tsullivan
tsullivan commented Mar 31, 2023
View reviewed changes
packages/core/chrome/core-chrome-browser-internal/src/ui/project/navigation.tsx Outdated
Copy link
Copy Markdown
Member Author

@tsullivan tsullivan Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Dark color mode is currently not working with our EUI Collapsible Nav Groups: elastic/eui#6663

@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch from b436496 to eb2cb09 Compare March 31, 2023 17:04
@tsullivan tsullivan added ci:build-storybooks Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Mar 31, 2023
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 3 times, most recently from cb15ef9 to 6c060a2 Compare March 31, 2023 22:39
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch from 3d178b6 to 75cc549 Compare April 6, 2023 00:31
tsullivan
tsullivan commented Apr 6, 2023
View reviewed changes
packages/shared-ux/chrome/navigation/src/model/platform_nav/_locators.ts Outdated
Copy link
Copy Markdown
Member Author

@tsullivan tsullivan Apr 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting all locators in place: WIP

@tsullivan tsullivan mentioned this pull request Apr 10, 2023
Merged
11 tasks
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 2 times, most recently from 7c6452b to a85f2d4 Compare April 12, 2023 21:41
@clintandrewhall clintandrewhall force-pushed the serverless/poc/unified_navigation branch from a7af0ea to a0ccf6b Compare April 20, 2023 13:31
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 2 times, most recently from c7332cc to a92c3a3 Compare April 21, 2023 01:02
@clintandrewhall clintandrewhall force-pushed the serverless/poc/unified_navigation branch 2 times, most recently from cc1a802 to 89bd09c Compare April 21, 2023 02:28
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 3 times, most recently from 8da8c3e to e188e2b Compare April 25, 2023 21:28
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 5 times, most recently from bf27d44 to ac8cece Compare April 27, 2023 18:05
@tsullivan tsullivan changed the base branch from serverless/poc/unified_navigation to main April 27, 2023 18:06
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch from 6e2ec44 to 4572ce3 Compare April 27, 2023 18:17
@tsullivan tsullivan changed the title [SharedUx] New package for project-style navigation. Integration from Serverless Search POC [SharedUx/POC] New package for project-style navigation. Integration from Serverless Search POC Apr 27, 2023
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch 4 times, most recently from e8daf78 to 10691b3 Compare April 27, 2023 22:21
@tsullivan tsullivan force-pushed the serverless/poc/unified_shared_ux_navigation branch from 10691b3 to 85a3e03 Compare May 1, 2023 18:32
@tsullivan tsullivan mentioned this pull request May 1, 2023
Merged
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 1, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch 4 31 +27

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-ux-chrome-navigation 11 13 +2
serverless 6 8 +2
total +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/shared-ux-chrome-navigation 3 4 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
core 362.5KB 362.3KB -156.0B
serverless 4.9KB 5.0KB +59.0B
serverlessSearch 1.5KB 20.6KB +19.1KB ❌ 3.5KB over limit
total +19.0KB
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-browser 124 126 +2
@kbn/shared-ux-chrome-navigation 21 24 +3
serverless 7 9 +2
total +7

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
serverless 4 3 -1
total +4

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
serverless 4 3 -1
total +4

History

  • 💔 Build #124138 failed 10691b3e4f6f0395e3515b0996c39bc11ee8d806
  • 💔 Build #124079 failed 2b6c5775304ff3b0e283d61da8ad66c556ecfd7c
  • 💔 Build #124065 failed 4572ce32cba5c7b6a02f105649d8031ecef4aa76
  • 💔 Build #123737 failed 192cf1bd97a1a8813adf9d532134124cd1c87ea6
  • 💔 Build #123259 failed b30d3b3f1f92b2b5da9d03b35466c9906f653294

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan

tsullivan added a commit that referenced this pull request May 2, 2023
@tsullivan
[Serverless/Side Nav] Light mode for side nav background (#156293)
0bf005a 
## Summary

This removes the dark background of the side nav for serverless
projects.

Pulled from #153508

Context from @MichaelMarcialis 
> current plans for the next revision is to ditch the high contrast nav
and header in favor of one that honors the current theme mode (light for
light and dark for dark).

## Screenshots
**Before**
<img width="1912" alt="light mode before"
src="https://user-images.githubusercontent.com/908371/235507715-5a094c83-b644-4cfa-946e-bc7183d393f5.png">

**After**
<img width="1912" alt="light mode after"
src="https://user-images.githubusercontent.com/908371/235507752-fa4e6548-f587-4bc2-93f4-f900aef542a1.png">
@tsullivan
Copy link
Copy Markdown
Member Author

tsullivan commented May 3, 2023

No longer needed. Replaced with #156465

@tsullivan tsullivan closed this May 3, 2023
@tsullivan tsullivan deleted the serverless/poc/unified_shared_ux_navigation branch November 21, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tsullivan tsullivan

Labels

Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t//

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsullivan @kibana-ci