-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[SharedUx/POC] New package for project-style navigation. Integration from Serverless Search POC #153508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tsullivan
wants to merge
6
commits into
elastic:main
from
tsullivan:serverless/poc/unified_shared_ux_navigation
Closed
[SharedUx/POC] New package for project-style navigation. Integration from Serverless Search POC #153508
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dd825ff
Light mode for side nav
tsullivan fb4e6ea
add solution side nav to serverless search
tsullivan dd1463a
Add necessary serverless and chrome extensions
tsullivan 1e0aaf8
add recent items
tsullivan b43f859
Organize code files
tsullivan 85a3e03
Recently accessed items filter prop
tsullivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
58 changes: 58 additions & 0 deletions
58
packages/shared-ux/chrome/navigation/src/ui/components/header.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { EuiHeaderLogo, EuiLoadingSpinner } from '@elastic/eui'; | ||
| import React from 'react'; | ||
| import useObservable from 'react-use/lib/useObservable'; | ||
| import { NavigationProps, NavigationServices } from '../../../types'; | ||
| import { getI18nStrings } from '../../i18n_strings'; | ||
| import { ElasticMark } from './elastic_mark'; | ||
| import './header_logo.scss'; | ||
|
|
||
| type Props = Pick<NavigationProps, 'homeHref'>; | ||
| type Services = Pick< | ||
| NavigationServices, | ||
| 'basePath' | 'navIsOpen' | 'navigateToUrl' | 'loadingCount$' | ||
| >; | ||
|
|
||
| export const NavHeader = (props: Props & Services) => { | ||
| const strings = getI18nStrings(); | ||
| const { basePath, navIsOpen, navigateToUrl, loadingCount$, homeHref } = props; | ||
|
|
||
| const loadingCount = useObservable(loadingCount$, 0); | ||
| const homeUrl = basePath.prepend(homeHref); | ||
| const navigateHome = (event: React.MouseEvent) => { | ||
| event.preventDefault(); | ||
| navigateToUrl(homeUrl); | ||
| }; | ||
| const logo = | ||
| loadingCount === 0 ? ( | ||
| <EuiHeaderLogo | ||
| iconType="logoElastic" | ||
| aria-label={strings.headerLogoAriaLabel} | ||
| onClick={navigateHome} | ||
| data-test-subj="nav-header-logo" | ||
| /> | ||
| ) : ( | ||
| <a href={homeUrl} onClick={navigateHome}> | ||
| <EuiLoadingSpinner | ||
| size="l" | ||
| aria-hidden={false} | ||
| onClick={navigateHome} | ||
| data-test-subj="nav-header-loading-spinner" | ||
| /> | ||
| </a> | ||
| ); | ||
|
|
||
| return ( | ||
| <> | ||
| {logo} | ||
| {navIsOpen ? <ElasticMark className="chrHeaderLogo__mark" aria-hidden={true} /> : null} | ||
| </> | ||
| ); | ||
| }; |
File renamed without changes.
12 changes: 12 additions & 0 deletions
12
packages/shared-ux/chrome/navigation/src/ui/components/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
| * in compliance with, at your election, the Elastic License 2.0 or the Server | ||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| export { NavHeader } from './header'; | ||
| export { LinkToCloud } from './link_to_cloud'; | ||
| export { NavigationBucket } from './navigation_bucket'; | ||
| export { RecentlyAccessed } from './recently_accessed'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: Dark color mode is currently not working with our EUI Collapsible Nav Groups: elastic/eui#6663