Skip to content

[Serverless/Side Nav] Light mode for side nav background#156293

Merged
tsullivan merged 1 commit intoelastic:mainfrom
tsullivan:serverless/nav/light-mode
May 2, 2023
Merged

[Serverless/Side Nav] Light mode for side nav background#156293
tsullivan merged 1 commit intoelastic:mainfrom
tsullivan:serverless/nav/light-mode

Conversation

@tsullivan
Copy link
Copy Markdown
Member

Summary

This removes the dark background of the side nav for serverless projects.

Pulled from #153508

Context from @MichaelMarcialis

current plans for the next revision is to ditch the high contrast nav and header in favor of one that honors the current theme mode (light for light and dark for dark).

Screenshots

Before
light mode before

After
light mode after

@tsullivan tsullivan requested a review from a team as a code owner May 1, 2023 18:36
@tsullivan tsullivan changed the title Light mode for side nav [Serverless/Side Nav] Light mode for side nav background May 1, 2023
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels May 1, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 362.5KB 362.3KB -127.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsullivan tsullivan merged commit 0bf005a into elastic:main May 2, 2023
@tsullivan tsullivan deleted the serverless/nav/light-mode branch May 2, 2023 17:06
@kibanamachine kibanamachine added v8.9.0 backport:skip This PR does not require backporting labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants