[DataViews] Remove `No matching indices found` toasts 🍞 by kertal · Pull Request #151788 · elastic/kibana

kertal · 2023-02-21T20:15:40Z

Summary

This is a toast-flavored SDH investigation that became a PR ...
Fixes #151670

This PR removes the No matching indices found toasts, part of some toast storms . The toasts were triggered when there were no matching indices of a given data view's index pattern.

If indication is needed, that there are no available matching indices (it could also be an issue of lack of permissions to the requested indices), it's easy to check following property of an existing data view, if the length of matchedIndices is 0, this equals a 'indices are missing condition`.

kibana/src/plugins/data_views/common/data_views/data_view.ts

Lines 151 to 153 in c7b742c

    
              * list of indices that the index pattern matched 
        
              */ 
        
             public matchedIndices: string[] = [];

Examples for 🍞 not being displayed because of this:

Testing

Install our demo data
Navigate to Transforms , create a transform based on one of demo data sets, more transforms based on different data views ... more toasts
Delete the indices containing the data in Console, but not the data views
Navigate to Transforms ... no toasts
Also there shall be no toast displayed showing the demo dashboards
There might be other areas of Discover without toasts
Neithertheless you can have a toast for breakfast, that's ok!

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2023-02-22T21:02:29Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

mattkime

Changes look good and work well!

neptunian · 2023-02-27T13:03:44Z

Is there a plan to remove allowNoIndex or is that still being used in some way?

mattkime · 2023-02-27T13:19:28Z

@neptunian I think it still preserves the field list if its saved to the data view. That said, there's some allowNoIndices related code that can be removed from the data views api.

…g-indices

kibana-ci · 2023-03-06T10:52:37Z

💚 Build Succeeded

Buildkite Build
Commit: cf87aa8

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dataViews`	44.2KB	43.9KB	-285.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	428	430	+2

Total ESLint disabled count

id	before	after	diff
`securitySolution`	506	508	+2

History

💚 Build #109592 succeeded 23d41fc
💔 Build #109439 failed 0fc1962

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

## Summary This PR removes the `No matching indices found ` toasts, part of some toast storms . The toasts were triggered when there were no matching indices of a given data view's index pattern. If indication is needed, that there are no available matching indices (it could also be an issue of lack of permissions to the requested indices), it's easy to check following property of an existing data view, if the length of matchedIndices is 0, this equals a 'indices are missing condition`.

… empty field list (#152059) ## Summary Part of #151670 and follow up to #151788 When a data view is loaded, it automatically loads its field list. Previously, it would error if the index pattern failed to match an index. Going forward, this will be treated as a valid empty state - `allowNoIndices` is being passed to the field_caps requests. When `allowNoIndices` is set to true, ES will return a valid empty set rather than a 404 error. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

… empty field list (elastic#152059) ## Summary Part of elastic#151670 and follow up to elastic#151788 When a data view is loaded, it automatically loads its field list. Previously, it would error if the index pattern failed to match an index. Going forward, this will be treated as a valid empty state - `allowNoIndices` is being passed to the field_caps requests. When `allowNoIndices` is set to true, ES will return a valid empty set rather than a 404 error. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary #151788 established that data views would no longer error when they failed to retrieve a field list. This index pattern validation code exists since previously ALL index pattern segments needed to match in order to avoid an error response from field caps, rather than just one. Now we can remove the validation code and simply pass the index pattern to field caps directly. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary Since #151788 landed, there's no need to insert `allowNoIndex` at the Lens level. Still no toasts: <img width="1901" alt="Screenshot 2023-03-29 at 4 30 58 PM" src="https://user-images.githubusercontent.com/315764/228676314-b9ba2add-a404-43ec-a9d8-b1d3b562ba2f.png"> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>

dont toast

d6eb1d1

kertal added the Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// label Feb 21, 2023

kertal self-assigned this Feb 21, 2023

kertal added 2 commits February 21, 2023 22:10

Add onMissingIndices callback

0fc1962

Cleanup

4068038

kertal changed the title ~~Discover don't toast when indices are missing~~ Add onMissingIndices to DataViews API handing the state of missing indices seperately Feb 22, 2023

Implement simpler approach

23d41fc

kertal changed the title ~~Add onMissingIndices to DataViews API handing the state of missing indices seperately~~ Remove triggering of onNotification when a there are no available indices matching the given data view index pattern Feb 22, 2023

kertal changed the title ~~Remove triggering of onNotification when a there are no available indices matching the given data view index pattern~~ Remove triggering of onNotification when there are no available indices matching the given data view index pattern Feb 22, 2023

kertal changed the title ~~Remove triggering of onNotification when there are no available indices matching the given data view index pattern~~ [DataViews] Remove triggering of onNotification when there are no available indices matching the given data view index pattern Feb 22, 2023

kertal added release_note:skip Skip the PR/issue when compiling release notes Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Feb 22, 2023

kertal changed the title ~~[DataViews] Remove triggering of onNotification when there are no available indices matching the given data view index pattern~~ [DataViews] Remove toasts when there are no available indices matching the given index pattern Feb 22, 2023

kertal changed the title ~~[DataViews] Remove toasts when there are no available indices matching the given index pattern~~ [DataViews] Remove No matching indices toasts 🍞 Feb 22, 2023

kertal changed the title ~~[DataViews] Remove No matching indices toasts 🍞~~ [DataViews] Remove No matching indices found toasts 🍞 Feb 22, 2023

kertal marked this pull request as ready for review February 22, 2023 21:02

kertal requested a review from a team as a code owner February 22, 2023 21:02

kertal mentioned this pull request Feb 23, 2023

Change field fetching behavior to automatically add allow_no_index=true when set to ES #151682

Closed

9 tasks

mattkime mentioned this pull request Feb 24, 2023

[data views] Automatic loading of field lists will no longer error on empty field list #152059

Merged

1 task

mattkime approved these changes Feb 24, 2023

View reviewed changes

kertal added 2 commits March 6, 2023 10:05

Merge main, fix conflicts

eb73004

Merge remote-tracking branch 'upstream/main' into data-view-no-missin…

cf87aa8

…g-indices

kertal merged commit ec690bc into elastic:main Mar 6, 2023

kibanamachine added v8.8.0 backport:skip This PR does not require backporting labels Mar 6, 2023

kertal mentioned this pull request Mar 7, 2023

[DataView] Fix multiple pattern matching #152552

Closed

mattkime mentioned this pull request Mar 21, 2023

[data views] Remove partial index pattern validation #153350

Merged

1 task

drewdaemon mentioned this pull request Mar 29, 2023

[Lens] remove automatic allowNoIndex from ad-hoc data views #154006

Merged

davismcphee mentioned this pull request Apr 11, 2023

[Search] debounce error/warning toasts #116686

Closed

kertal mentioned this pull request May 30, 2023

Creating index pattern with Saved Objects API before matching indices exists throws misleading/vague error. #57645

Closed

kertal mentioned this pull request Oct 30, 2023

Index Pattern overwritten when an index exists #65284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataViews] Remove `No matching indices found` toasts 🍞#151788

[DataViews] Remove `No matching indices found` toasts 🍞#151788
kertal merged 6 commits intoelastic:mainfrom
kertal:data-view-no-missing-indices

kertal commented Feb 21, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Feb 22, 2023

Uh oh!

mattkime left a comment

Uh oh!

neptunian commented Feb 27, 2023

Uh oh!

mattkime commented Feb 27, 2023

Uh oh!

kibana-ci commented Mar 6, 2023

ESLint disabled line counts

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	* list of indices that the index pattern matched
	*/
	public matchedIndices: string[] = [];

Conversation

kertal commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Checklist

Uh oh!

elasticmachine commented Feb 22, 2023

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

neptunian commented Feb 27, 2023

Uh oh!

mattkime commented Feb 27, 2023

Uh oh!

kibana-ci commented Mar 6, 2023

💚 Build Succeeded

Metrics [docs]

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kertal commented Feb 21, 2023 •

edited

Loading