Skip to content

[data views] Remove partial index pattern validation#153350

Merged
mattkime merged 11 commits intoelastic:mainfrom
mattkime:remove_partial_index_pattern_validation
Mar 27, 2023
Merged

[data views] Remove partial index pattern validation#153350
mattkime merged 11 commits intoelastic:mainfrom
mattkime:remove_partial_index_pattern_validation

Conversation

@mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 21, 2023

Summary

#151788 established that data views would no longer error when they failed to retrieve a field list. This index pattern validation code exists since previously ALL index pattern segments needed to match in order to avoid an error response from field caps, rather than just one. Now we can remove the validation code and simply pass the index pattern to field caps directly.

Checklist

Delete any items that are not applicable to this PR.

@mattkime mattkime changed the title remove partial index pattern validation [data views] Remove partial index pattern validation Mar 21, 2023
@mattkime mattkime added v8.8.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Mar 21, 2023
@kertal
Copy link
Member

kertal commented Mar 23, 2023

@elasticmachine merge upstream

@mattkime mattkime marked this pull request as ready for review March 25, 2023 05:03
@mattkime mattkime requested review from a team as code owners March 25, 2023 05:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Mar 25, 2023
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 39.7KB 39.7KB +18.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 88.2KB 88.3KB +70.0B
Unknown metric groups

API count

id before after diff
data 3273 3271 -2
dataViews 1031 1029 -2
total -4

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime requested a review from jughosta March 26, 2023 22:39
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM 👍

@mattkime mattkime merged commit 29f0380 into elastic:main Mar 27, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants