Skip to content

Change field fetching behavior to automatically add allow_no_index=true when set to ES#151682

Closed
kertal wants to merge 9 commits intoelastic:mainfrom
kertal:data-views-allowNoIndex-default-true
Closed

Change field fetching behavior to automatically add allow_no_index=true when set to ES#151682
kertal wants to merge 9 commits intoelastic:mainfrom
kertal:data-views-allowNoIndex-default-true

Conversation

@kertal
Copy link
Member

@kertal kertal commented Feb 21, 2023

Summary

WIP to evaluate what happens when setting allow_no_index to true if not requested differently. In the UI this resolves the following toast storms, happening when the underlying indices are deleted
Bildschirmfoto 2023-02-21 um 11 05 31
Bildschirmfoto 2023-02-21 um 11 08 17

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kertal kertal added the Feature:Data Views Data Views code and UI - index patterns before 8.0 label Feb 21, 2023
@kertal kertal self-assigned this Feb 21, 2023
type: options.type,
rollupIndex: options.rollupIndex,
allowNoIndex: options.allowNoIndex,
allowNoIndex: options.allowNoIndex ?? true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattkime FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since these are private functions we can just permanently set these to true.

@kibana-ci
Copy link

kibana-ci commented Feb 22, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / discover/group1 discover filter editor filter editor version fields should support range filter on version fields
  • [job] [logs] FTR Configs #32 / discover/group1 discover filter editor filter editor version fields should support range filter on version fields
  • [job] [logs] FTR Configs #32 / discover/group1 discover sidebar renders field groups should work correctly for a data view for a missing index
  • [job] [logs] FTR Configs #32 / discover/group1 discover sidebar renders field groups should work correctly for a data view for a missing index
  • [job] [logs] FTR Configs #54 / rollup app hybrid index pattern create hybrid index pattern
  • [job] [logs] FTR Configs #54 / rollup app hybrid index pattern create hybrid index pattern

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 44.0KB 44.1KB +88.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal
Copy link
Member Author

kertal commented Feb 23, 2023

closing in favor of #151788

@kertal kertal closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Data Views Data Views code and UI - index patterns before 8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants