[Security Solution] Explore Sub Plugin Part 1- Consolidate into Explore Directory#147298
Merged
stephmilovic merged 16 commits intoelastic:mainfrom Dec 13, 2022
Merged
[Security Solution] Explore Sub Plugin Part 1- Consolidate into Explore Directory#147298stephmilovic merged 16 commits intoelastic:mainfrom
stephmilovic merged 16 commits intoelastic:mainfrom
Conversation
stephmilovic
added
technical debt
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
Author
Files by Code Ownerelastic/awp-viz
elastic/security-detections-response-rules
elastic/security-solution
elastic/security-threat-hunting-explore
elastic/security-threat-hunting-investigations
|
spong
approved these changes
Dec 12, 2022
Member
spong
left a comment
spong
left a comment
There was a problem hiding this comment.
Approving for Detection Rule changes 👍.
Only change was to rule_details/index.tsx, which was an update to an import that now lives within the explore sub-dir.
machadoum
approved these changes
Dec 13, 2022
This was referenced Jan 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of the work described here. In this PR, explore code was moved only. Creating the explore sub plugin will be part 2 (draft PR, will reopen against
mainonce this PR is merged).Consolidate into explore directory
1. The following directories have been moved within
public/explore:public/hosts=>public/explore/hostspublic/network=>public/explore/networkpublic/users=>public/explore/users2. components/containers that are solely or primarily being consumed by files within the new explore directory above
public/explore/components/public/explore/containers:public/common/components/authentications=>public/explore/components/authenticationspublic/common/containers/authentications=>public/explore/containers/authenticationspublic/common/components/paginated_table=>public/explore/components/paginated_tablepublic/common/components/stat_items=>public/explore/components/stat_itemspublic/risk_score=>public/explore/components/risk_score/public/explore/containers/risk_scorepublic/common/components/severity=>public/explore/components/risk_score/severitypublic/common/components/top_risk_score_contributers=>public/explore/components/risk_score/top_risk_score_contributers3.
CODEOWNERSfile updated to reflect these changes4. Consolidate the 3
jest.config.jsfiles into one underpublic/explore/jest.config.js