[Security solution] Fix side effects in useRefetchByRestartingSession

[stephmilovic]

Summary

I noticed the below console error on the network page and tracked it down to the searchSessionId variable in useRefetchByRestartingSession which was previously stored in a useMemo. The hook calls data.search.session.start() which returns the id. However, this call was running before the component was mounted and react did not like it, resulting in the error. Fixed by storing the id in useState and updating the state with the start() call once the component is mounted

Warning: Cannot update a component (`Unknown`) while rendering a different component (`NetworkKpiUniquePrivateIpsComponent`). To locate the bad setState() call inside `NetworkKpiUniquePrivateIpsComponent`, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
    at NetworkKpiUniquePrivateIpsComponent (http://localhost:5601/kbn/9007199254740991/bundles/plugin/securitySolution/8.0.0/securitySolution.chunk.lazy_sub_plugins.js:185537:3)
    at div
    ... very long log

I also moved this hook to be in public/explore in accordance with #147298

[stephmilovic]

I updated this to use the session.current ref since its the only place we're not using the ref. I think it was done like this in the first place because of the following error:

ESLint: The ref value 'session.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'session.current' to a variable inside the effect, and use that variable in the cleanup function.(react-hooks/exhaustive-deps)

Thus the variable on L62

[stephmilovic]

react wants empty dependency argument now that we're using a setState call in the effect

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[stephmilovic]

I happened to notice this was the only chart embeddables query without this condition, I think this is correct??

[angorayc]

Thanks for adding the check!

[stephmilovic]

@elasticmachine merge upstream

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: ee27615
• Interpreting CI Failures

Failed CI Steps

• FTR Configs #21
• Security Solution Tests #1
• Security Solution Tests #3
• Security Solution Tests #3
• Security Solution Tests #4

Test Failures

• [job] [logs] Security Solution Tests #4 / Add exception using data views from rule details Creates an exception item from alert actions overflow menu
• [job] [logs] FTR Configs #21 / alerting api integration security and spaces enabled - Group 2 Alerts alerts alerts space_1_all_with_restricted_fixture at space1 should schedule task, run alert and schedule actions when appropriate
• [job] [logs] Security Solution Tests #1 / Detections : Page Filters Alert list is updated when the alerts are updated
• [job] [logs] Security Solution Tests #1 / Detections : Page Filters URL is updated when filters are updated
• [job] [logs] Security Solution Tests #3 / Timelines Creates a timeline by clicking untitled timeline from bottom bar can be added notes
• [job] [logs] Security Solution Tests #3 / Timelines Creates a timeline by clicking untitled timeline from bottom bar can be added notes

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	12.7MB	12.7MB	+22.0B

History

• 💔 Build #98940 failed f181923
• 💔 Build #98934 failed 5711fa8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[jamster10]

Good solution, thank you!

[stephmilovic]

closing in favor of #148552