[Security Solution] Explore Sub Plugin Part 2- Combine Network, Hosts, Users into one Explore Sub Plugin#147468
Conversation
stephmilovic
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
| storageDataTables?: Pick<TableState, 'tableById'>; | ||
| exploreDataTables?: { | ||
| network: Pick<TableState, 'tableById'>; | ||
| hosts: Pick<TableState, 'tableById'>; |
There was a problem hiding this comment.
I'm not sure why, but users never actually utilized this storage.
| users: Reducer<UsersState, AnyAction>; | ||
| } | ||
|
|
||
| export class Explore { |
There was a problem hiding this comment.
@YulNaumenko @elastic/security-threat-hunting-explore this is the part that needs some opinion. I added exploreDataTables to make typing this easier. Note that users never utilized the local storage table feature, should it be there? Not sure I totally understand/remember this feature
There was a problem hiding this comment.
I don't think we have the local storage cleanup or utilize functionality, but we have a migration logic:
Do you think this is something you can use for your case?
|
@elasticmachine merge upstream |
machadoum
left a comment
machadoum
left a comment
There was a problem hiding this comment.
The code looks good, and explores pages are working fine. 👍
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
6 participants
This is part 2 of the work described #143574. In the first PR, explore code was moved only. In this PR we create the Explore sub plugin.