Skip to content

Removes module core/server/types#147223

Merged
TinaHeiligers merged 8 commits intoelastic:mainfrom
TinaHeiligers:IDM-remove-core-server-types-module
Dec 13, 2022
Merged

Removes module core/server/types#147223
TinaHeiligers merged 8 commits intoelastic:mainfrom
TinaHeiligers:IDM-remove-core-server-types-module

Conversation

@TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Dec 7, 2022 •
edited
Loading

Part of #145479
fix #145065

Removes core/server/types.

Reviewers: This PR is part of the Internal Dependency Management initiative. The types that were exposed from core/server/types weren't intended for public consumption.

@TinaHeiligers TinaHeiligers added chore Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.7.0 labels Dec 7, 2022
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 8, 2022

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 8, 2022

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 8, 2022

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 9, 2022

@elasticmachine merge upstream

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 10, 2022

@elastic/response-ops I need help with the Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution Cypress tests that are failing. These are failing globally, even with a no-op PR.

@ymao1
Copy link
Contributor

ymao1 commented Dec 12, 2022

@TinaHeiligers Those are tests under x-pack/test/security_solution_cypress and owned by @elastic/security-engineering-productivity

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 12, 2022

@MadameSheema I'm rebasing against main now.

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 12, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Dec 12, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #42 / APM API tests basic no data Service group counts with alerts "before all" hook for "returns the correct number of alerts"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 1010 1013 +3
Unknown metric groups

API count

id before after diff
core 2803 2806 +3

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

References to deprecated APIs

id before after diff
core 8 7 -1

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as ready for review December 12, 2022 17:34
@TinaHeiligers TinaHeiligers requested review from a team as code owners December 12, 2022 17:34
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2022

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Dec 12, 2022

@ogupte The flaky test is the one added in #144484. We may need to watch that test for more failures.

pmuellr
pmuellr approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM!

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 12, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2022

Pinging @elastic/fleet (Team:Fleet)

alisonelizabeth
alisonelizabeth approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade Assistant changes LGTM

pgayvallet
pgayvallet approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

criamico
criamico approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

@TinaHeiligers TinaHeiligers merged commit f770625 into elastic:main Dec 13, 2022
@TinaHeiligers TinaHeiligers deleted the IDM-remove-core-server-types-module branch December 13, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmuellr pmuellr pmuellr approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@criamico criamico criamico approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IDM: Get rid of src/core/server/types.ts

9 participants

@TinaHeiligers @ymao1 @kibana-ci @elasticmachine @pmuellr @pgayvallet @alisonelizabeth @criamico @kibanamachine