Skip to content

Removes module core/server/types #147223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TinaHeiligers merged 8 commits into from
Dec 13, 2022
Merged

Removes module core/server/types #147223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe41541
Removes module core/server/types
TinaHeiligers Dec 7, 2022
f8e5db2
Updates imports to read from packages
TinaHeiligers Dec 8, 2022
9a30b7c
Merge branch 'main' into IDM-remove-core-server-types-module
kibanamachine Dec 8, 2022
09dc7b3
Merge branch 'main' into IDM-remove-core-server-types-module
kibanamachine Dec 8, 2022
a9ced06
Merge branch 'main' into IDM-remove-core-server-types-module
kibanamachine Dec 8, 2022
3a613c9
Merge branch 'main' into IDM-remove-core-server-types-module
kibanamachine Dec 9, 2022
5540fe4
import from src/core/server rather than directly from packages
TinaHeiligers Dec 9, 2022
4f96521
Merge branch 'main' into IDM-remove-core-server-types-module
kibanamachine Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/core/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,11 @@ export type {
DeprecationsClient,
DeprecationsRequestHandlerContext,
} from '@kbn/core-deprecations-server';
export type { DeprecationsDetails } from '@kbn/core-deprecations-common';
export type {
DeprecationsDetails,
DomainDeprecationDetails,
DeprecationsGetResponse,
} from '@kbn/core-deprecations-common';

export type { AppCategory } from '@kbn/core-application-common';
export { DEFAULT_APP_CATEGORIES, APP_WRAPPER_CLASS } from '@kbn/core-application-common';
Expand Down
62 changes: 0 additions & 62 deletions src/core/server/types.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/api_integration/apis/data_views/deprecations/scripted_fields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import expect from '@kbn/expect';
import type { DeprecationsGetResponse } from '@kbn/core/server/types';
import type { DeprecationsGetResponse } from '@kbn/core/server';
import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService }: FtrProviderContext) {
Expand Down
3 changes: 2 additions & 1 deletion test/plugin_functional/test_suites/core/deprecations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
*/

import expect from '@kbn/expect';
import type { DomainDeprecationDetails, DeprecationsGetResponse } from '@kbn/core/server/types';

import type { ResolveDeprecationResponse } from '@kbn/core/public';
import type { DeprecationsGetResponse, DomainDeprecationDetails } from '@kbn/core/server';
import { PluginFunctionalProviderContext } from '../../services';

export default function ({ getService, getPageObjects }: PluginFunctionalProviderContext) {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/actions/server/lib/action_task_params_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { SavedObjectAttribute, SavedObjectReference } from '@kbn/core/server/types';
import { SavedObjectAttribute, SavedObjectReference } from '@kbn/core/server';
import { RelatedSavedObjects } from './related_saved_objects';

export const ACTION_REF_NAME = `actionRef`;
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/fleet/server/services/epm/kibana/assets/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import type {
SavedObjectsBulkCreateObject,
SavedObjectsClientContract,
ISavedObjectsImporter,
SavedObjectsImportSuccess,
SavedObjectsImportFailure,
Logger,
} from '@kbn/core/server';
import type { SavedObjectsImportSuccess, SavedObjectsImportFailure } from '@kbn/core/server/types';
import { createListStream } from '@kbn/utils';
import { partition } from 'lodash';

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/upgrade_assistant/server/lib/kibana_status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import { deprecationsServiceMock } from '@kbn/core/server/mocks';
import { DomainDeprecationDetails } from '@kbn/core/server/types';
import type { DomainDeprecationDetails } from '@kbn/core/server';

import { getKibanaUpgradeStatus } from './kibana_status';

Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/upgrade_assistant/server/lib/kibana_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
* 2.0.
*/

import { DeprecationsClient } from '@kbn/core/server';
import { DomainDeprecationDetails } from '@kbn/core/server/types';
import { DeprecationsClient, DomainDeprecationDetails } from '@kbn/core/server';

export const getKibanaUpgradeStatus = async (deprecationsClient: DeprecationsClient) => {
const kibanaDeprecations: DomainDeprecationDetails[] =
Expand Down