[DataViews] Fix form validation UX when the same data view name already exists#146126
Merged
jughosta merged 4 commits intoelastic:mainfrom Nov 25, 2022
Merged
[DataViews] Fix form validation UX when the same data view name already exists#146126jughosta merged 4 commits intoelastic:mainfrom
jughosta merged 4 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:fix
Feature:Data Views
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
reviewed
Nov 23, 2022
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
These changes LGTM, but I noticed the error handling still doesn't work when the data view name is auto generated from the pattern. Would you like to fix that as part of this PR, or would you prefer I create a separate issue for the problem?
Contributor
Author
|
@davismcphee I don't have a solution for the problem you mentioned. Let's create a separate issue. |
davismcphee
approved these changes
Nov 25, 2022
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
@davismcphee I don't have a solution for the problem you mentioned. Let's create a separate issue.
Sounds good, created: #146338. And in that case, this LGTM.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @jughosta |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 28, 2022
* main: (30 commits) [Cloud Posture] test latest findings table sort (elastic#144668) [api-docs] 2022-11-28 Daily api_docs build (elastic#146359) [api-docs] 2022-11-27 Daily api_docs build (elastic#146353) [api-docs] 2022-11-26 Daily api_docs build (elastic#146350) [DataViews] Fix form validation UX when the same data view name already exists (elastic#146126) [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (elastic#145583) [Health Gateway] Update response aggregation (elastic#145761) [api-docs] 2022-11-25 Daily api_docs build (elastic#146341) [Metric threshold rule] Adds new context variable for group by keys (elastic#145654) [Controls] [Portable Dashboards] Add control group renderer example plugin (elastic#146189) Refactor Observability Overview Page (elastic#146182) Send complete test data to xMatters, so it can create an alert (elastic#145431) [Dashboard] [Controls] Allow options list suggestions to be sorted (elastic#144867) Add open API specification for list connector types (elastic#145951) skip flaky suite (elastic#146086) [ML] Removing duplicate tooltip text (elastic#146308) Refactor Rules Page (elastic#146193) [DOCS] Alert limit for cases (elastic#145950) Extend session index fields mapping with a session creation timestamp. (elastic#145997) [Files] Move <Image /> component to `@kbn/shared-ux` package (elastic#145995) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138958
Summary
This PR fixes form UX when the same data view name already exists.