[Cloud Posture] test latest findings table sort by orouz · Pull Request #144668 · elastic/kibana

orouz · 2022-11-06T18:37:33Z

Summary

this PR incudes initial setup and tests for cloud-posture's functional tests (for Findings)
it takes about 1.5 minutes to run in total. (including es/kibana, actual test run in about 25s)

a follow-up PR will include details on how to run/add FTR tests in our README file.

local testing:

development
- server: yarn test:ftr:server --config x-pack/test/cloud_security_posture_functional/config.ts --debug
- runner: yarn test:ftr:runner --config x-pack/test/cloud_security_posture_functional/config.ts
CI
- both: node scripts/functional_tests.js --config x-pack/test/cloud_security_posture_functional/config.ts

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts

x-pack/plugins/cloud_security_posture/server/plugin.ts

x-pack/plugins/cloud_security_posture/server/routes/status/status.ts

x-pack/test/cloud_security_posture_functional/config.ts

elasticmachine · 2022-11-14T17:10:48Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

kfirpeled

For some reason it didn't worked for me locally, from the view of it, it doesn't change the current page size from 25 to 10
This could be due to that we save in localstorage the user preference - I would recommend that part of your tests you'll always set the page size to be 10. Because you are relaying on this step on your pagination tests.

x-pack/plugins/cloud_security_posture/server/plugin.ts

x-pack/plugins/cloud_security_posture/server/routes/status/status.ts

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts

x-pack/plugins/cloud_security_posture/server/plugin.ts

x-pack/test/cloud_security_posture_functional/pages/findings.ts

x-pack/plugins/cloud_security_posture/server/plugin.ts

x-pack/plugins/cloud_security_posture/server/routes/status/status.ts

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts

kibana-ci · 2022-11-27T21:15:56Z

💚 Build Succeeded

Buildkite Build
Commit: 7f3d80e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	127.0KB	127.0KB	+37.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	109	115	+6
`securitySolution`	443	449	+6
total			+20

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	68	74	+6
`osquery`	110	117	+7
`securitySolution`	520	526	+6
total			+21

History

💛 Build #90842 was flaky 00c76cf
💚 Build #90345 succeeded a025423
💛 Build #90021 was flaky bdd1328
💚 Build #89753 succeeded 5b8ab5d
💔 Build #89741 failed 8dca307
💚 Build #89494 succeeded 7673e4c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* main: (30 commits) [Cloud Posture] test latest findings table sort (elastic#144668) [api-docs] 2022-11-28 Daily api_docs build (elastic#146359) [api-docs] 2022-11-27 Daily api_docs build (elastic#146353) [api-docs] 2022-11-26 Daily api_docs build (elastic#146350) [DataViews] Fix form validation UX when the same data view name already exists (elastic#146126) [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (elastic#145583) [Health Gateway] Update response aggregation (elastic#145761) [api-docs] 2022-11-25 Daily api_docs build (elastic#146341) [Metric threshold rule] Adds new context variable for group by keys (elastic#145654) [Controls] [Portable Dashboards] Add control group renderer example plugin (elastic#146189) Refactor Observability Overview Page (elastic#146182) Send complete test data to xMatters, so it can create an alert (elastic#145431) [Dashboard] [Controls] Allow options list suggestions to be sorted (elastic#144867) Add open API specification for list connector types (elastic#145951) skip flaky suite (elastic#146086) [ML] Removing duplicate tooltip text (elastic#146308) Refactor Rules Page (elastic#146193) [DOCS] Alert limit for cases (elastic#145950) Extend session index fields mapping with a session creation timestamp. (elastic#145997) [Files] Move <Image /> component to `@kbn/shared-ux` package (elastic#145995) ...

orouz force-pushed the csp_test_findings branch from edcd16d to 050396d Compare November 6, 2022 19:11

orouz linked an issue Nov 6, 2022 that may be closed by this pull request

[Cloud Posture] Add functional tests for Findings Table #140490

Closed

8 tasks

orouz commented Nov 8, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts Outdated Show resolved Hide resolved

orouz commented Nov 8, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts Outdated Show resolved Hide resolved

orouz commented Nov 8, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts Outdated Show resolved Hide resolved

orouz commented Nov 8, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts Outdated Show resolved Hide resolved

orouz force-pushed the csp_test_findings branch from 87bcfdb to 171de48 Compare November 10, 2022 16:32

update ftr configs

1c3745b

orouz force-pushed the csp_test_findings branch from b69ac9c to 6734388 Compare November 14, 2022 13:04

orouz added 2 commits November 14, 2022 15:42

update plugin status route

7756469

add findings archive file

b272b73

orouz force-pushed the csp_test_findings branch 2 times, most recently from 3b2f220 to 4478b07 Compare November 14, 2022 14:04

add ftr setup and tests

8db0b0f

orouz force-pushed the csp_test_findings branch from 4478b07 to 8db0b0f Compare November 14, 2022 15:28

orouz commented Nov 14, 2022

View reviewed changes

x-pack/plugins/cloud_security_posture/server/plugin.ts Outdated Show resolved Hide resolved

x-pack/plugins/cloud_security_posture/server/routes/status/status.ts Outdated Show resolved Hide resolved

x-pack/test/cloud_security_posture_functional/config.ts Show resolved Hide resolved

orouz added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.6.0 labels Nov 14, 2022

orouz marked this pull request as ready for review November 14, 2022 17:10

orouz requested review from a team as code owners November 14, 2022 17:10

jbudz approved these changes Nov 14, 2022

View reviewed changes

orouz requested review from ari-aviran and kfirpeled November 14, 2022 17:15

orouz added v8.7.0 and removed v8.6.0 labels Nov 16, 2022

orouz requested review from CohenIdo and gurevichdmitry November 17, 2022 11:48

orouz added 3 commits November 17, 2022 14:14

Merge branch 'main' into csp_test_findings

ff1f0ee

fix test

2939eb1

Merge remote-tracking branch 'upstream/main' into csp_test_findings

7673e4c

kfirpeled requested changes Nov 20, 2022

View reviewed changes

CohenIdo reviewed Nov 20, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/pages/findings.ts Outdated Show resolved Hide resolved

orouz added 4 commits November 21, 2022 18:37

review changes

c487e20

Merge remote-tracking branch 'upstream/main' into csp_test_findings

8dca307

fix stale element reference

2d8bf79

fix lint

5b8ab5d

orouz requested review from CohenIdo and kfirpeled November 22, 2022 09:36

clean

bdd1328

kfirpeled reviewed Nov 22, 2022

View reviewed changes

orouz commented Nov 22, 2022

View reviewed changes

x-pack/test/cloud_security_posture_functional/page_objects/findings_page.ts Outdated Show resolved Hide resolved

orouz added 3 commits November 23, 2022 15:55

fix false positive test

e23c44f

Merge branch 'main' into csp_test_findings

8ee9335

review fixes

a025423

kfirpeled self-requested a review November 24, 2022 15:44

kfirpeled approved these changes Nov 24, 2022

View reviewed changes

orouz added 3 commits November 27, 2022 20:58

remove pagination and clean

bffd145

Merge branch 'main' into csp_test_findings

00c76cf

clean and trigger ci

7f3d80e

orouz changed the title ~~[Cloud Posture] add tests to findings page~~ [Cloud Posture] test latest findings table sort Nov 28, 2022

orouz merged commit b9ffc29 into elastic:main Nov 28, 2022

kibanamachine added the backport:skip This PR does not require backporting label Nov 28, 2022

Conversation

orouz commented Nov 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 14, 2022

Uh oh!

kfirpeled left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibana-ci commented Nov 27, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

orouz commented Nov 6, 2022 •

edited

Loading

kfirpeled left a comment •

edited

Loading