[Health Gateway] Update response aggregation#145761
Merged
dokmic merged 7 commits intoelastic:mainfrom Nov 25, 2022
Merged
Conversation
dokmic
added
review
Team:Core
dokmic
force-pushed
the
feature/141885
branch
from
4049a39 to
02b1b92
Compare
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
lukeelmers
approved these changes
Nov 21, 2022
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this much-needed cleanup & adding tests!
dokmic
force-pushed
the
feature/141885
branch
from
02b1b92 to
0722189
Compare
rudolf
approved these changes
Nov 23, 2022
Contributor
rudolf
left a comment
rudolf
left a comment
There was a problem hiding this comment.
I'm a little bit unsure about exposing host urls and would err towards keeping it private (and relying on logs if we need full visibility), but I don't think it's a direct security threat.
packages/kbn-health-gateway-server/src/kibana/routes/root.test.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
why pick these methods instead of returning the whole class instance?
Contributor
Author
There was a problem hiding this comment.
That's because hapi complains about private methods that are not in their config schema.
dokmic
force-pushed
the
feature/141885
branch
from
0722189 to
6a40d8a
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 28, 2022
* main: (30 commits) [Cloud Posture] test latest findings table sort (elastic#144668) [api-docs] 2022-11-28 Daily api_docs build (elastic#146359) [api-docs] 2022-11-27 Daily api_docs build (elastic#146353) [api-docs] 2022-11-26 Daily api_docs build (elastic#146350) [DataViews] Fix form validation UX when the same data view name already exists (elastic#146126) [Discover] Prevent agg based visualizations of Discover saved objects with adhoc data views (elastic#145583) [Health Gateway] Update response aggregation (elastic#145761) [api-docs] 2022-11-25 Daily api_docs build (elastic#146341) [Metric threshold rule] Adds new context variable for group by keys (elastic#145654) [Controls] [Portable Dashboards] Add control group renderer example plugin (elastic#146189) Refactor Observability Overview Page (elastic#146182) Send complete test data to xMatters, so it can create an alert (elastic#145431) [Dashboard] [Controls] Allow options list suggestions to be sorted (elastic#144867) Add open API specification for list connector types (elastic#145951) skip flaky suite (elastic#146086) [ML] Removing duplicate tooltip text (elastic#146308) Refactor Rules Page (elastic#146193) [DOCS] Alert limit for cases (elastic#145950) Extend session index fields mapping with a session creation timestamp. (elastic#145997) [Files] Move <Image /> component to `@kbn/shared-ux` package (elastic#145995) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #141885.
Checklist