Skip to content

[Maps] nest security layers in layer group#144055

Merged
nreese merged 4 commits intoelastic:mainfrom
nreese:security_layer_group
Oct 27, 2022
Merged

[Maps] nest security layers in layer group#144055
nreese merged 4 commits intoelastic:mainfrom
nreese:security_layer_group

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Oct 26, 2022

#142528 added the ability to group layers. This feature was requested to allow for grouping security layers by index pattern, #41575 (comment).

Prior to this PR, security use case created 3 layers per index pattern

  • View of network map in Security
    Screen Shot 2022-10-26 at 9 40 57 AM
  • View of security layers added in Maps application
    Screen Shot 2022-10-26 at 9 41 28 AM

Now, with this PR, security use case creates 3 layers that are in a single group for the index pattern

  • View of network map in Security
    Screen Shot 2022-10-26 at 11 18 00 AM
  • View of security layers added in Maps application
    Screen Shot 2022-10-26 at 9 55 11 AM

@nreese nreese marked this pull request as ready for review October 26, 2022 17:44
@nreese nreese requested review from a team as code owners October 26, 2022 17:44
@nreese nreese changed the title Security layer group [Maps] nest security layers in layer group Oct 26, 2022
@nreese nreese added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v8.6.0 labels Oct 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +99.0B
securitySolution 9.6MB 9.6MB +145.0B
total +244.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tested in chrome and code review

@nreese nreese merged commit a21ed37 into elastic:main Oct 27, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 27, 2022
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
@sophiec20 sophiec20 added Feature:Maps and removed Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants