[Security Solution][Endpoint] Adds RBAC API checks for Blocklist#144047
Merged
dasansol92 merged 3 commits intoelastic:mainfrom Oct 27, 2022
Merged
[Security Solution][Endpoint] Adds RBAC API checks for Blocklist#144047dasansol92 merged 3 commits intoelastic:mainfrom
dasansol92 merged 3 commits intoelastic:mainfrom
Conversation
dasansol92
added
release_note:skip
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
ashokaditya
approved these changes
Oct 27, 2022
Member
ashokaditya
left a comment
ashokaditya
left a comment
There was a problem hiding this comment.
Tested the API and it works as expected. 🚢
|
|
||
| async validatePreExport(): Promise<void> { | ||
| await this.validateCanManageEndpointArtifacts(); | ||
| await this.validateHasWritePrivilege(); |
Contributor
There was a problem hiding this comment.
should this be checking for read since its not doing any updates?
Contributor
Author
There was a problem hiding this comment.
It was a request from @caitlinbetz. We did the same for the other artifacts.
Contributor
There was a problem hiding this comment.
oh. Ok. Its a bit strange - to be able to get/find, but I can't export.
There was a problem hiding this comment.
Sorry - I think I was confused previously. That makes sense to me. So those with read or all can export? I am good with that, apologies for the confusion!
paul-tavares
approved these changes
Oct 27, 2022
Contributor
Author
|
@paul-tavares I did the change for all artifacts here: 0afc570 |
paul-tavares
approved these changes
Oct 27, 2022
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 27, 2022
* main: (24 commits) [Files] Add file upload to file picker (elastic#143969) [Security solution] Guided onboarding, alerts & cases (elastic#143598) [APM] Critical path for a single trace (elastic#143735) skip failing test suite (elastic#143933) [Fleet] Update GH Projects automation (elastic#144123) [APM] Performance fix for 'cardinality' telemetry task (elastic#144061) [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979) [8.5][DOCS] Add support for differential logs (elastic#143242) Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001) [APM] Add waterfall to dependency operations (elastic#143257) [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766) [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047) Improve `needs-team` auto labeling regex (elastic#143787) [Reporting/CSV Export] _id field can not be formatted (elastic#143807) Adds SavedObjectsWarning to analytics results pages. (elastic#144109) Bump chromedriver to 107 (elastic#144073) Update cypress (elastic#143755) [Maps] nest security layers in layer group (elastic#144055) [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820) Added support of saved search (elastic#144095) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For maintainers