Skip to content

Improves needs-team auto labeling regex#143787

Merged
nickofthyme merged 3 commits intomainfrom
nickofthyme-update-relabel
Oct 27, 2022
Merged

Improves needs-team auto labeling regex#143787
nickofthyme merged 3 commits intomainfrom
nickofthyme-update-relabel

Conversation

@nickofthyme
Copy link
Contributor

Summary

Improves needs-team auto labeling regex

Improvement:

  • fix full-text matching (using ^ and $)
  • Adds EUI as a team
  • Prevent empty Team: search

See matching example between the old and new below...

Test label text Old regex New regex
Team:test
Team:
:ml
:mlTeam:test ✅ (both)
EUI

Improves `needs-team` auto labeling regex

Improvement:
- fix full-text matching (using `^` and `$`)
- Adds `EUI` as a team
- Prevent empty `Team:` search

See matching example between the old and new below...

| Test label text | Old regex | New regex |
|-----------------|-----------|-----------|
| `Team:test`     |     ✅     |     ✅     |
| `Team:`         |     ✅     |     ❌     |
| `:ml`           |     ✅     |     ✅     |
| `:mlTeam:test`  |  ✅ (both) |     ❌     |
| `EUI`           |     ❌     |     ✅     |
@nickofthyme nickofthyme added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting ci:skip-when-possible (Deprecated) no-op, managed automatically labels Oct 20, 2022
@nickofthyme nickofthyme added the Team:Operations Kibana-Operations Team label Oct 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested regex.

@nickofthyme nickofthyme changed the title Update relabel.yml Improves needs-team auto labeling regex Oct 27, 2022
@nickofthyme nickofthyme merged commit 1858444 into main Oct 27, 2022
@nickofthyme nickofthyme deleted the nickofthyme-update-relabel branch October 27, 2022 16:03
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 27, 2022
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:skip-when-possible (Deprecated) no-op, managed automatically release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants