Skip to content

[7.17] [TSVB] Fix shard failures are not reported (#123474)#124207

Merged
alexwizp merged 4 commits intoelastic:7.17from
alexwizp:backport/7.17/pr-123474
Feb 3, 2022
Merged

[7.17] [TSVB] Fix shard failures are not reported (#123474)#124207
alexwizp merged 4 commits intoelastic:7.17from
alexwizp:backport/7.17/pr-123474

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Feb 1, 2022

Backport

This is an automatic backport to 7.17 of:

Questions ?

Please refer to the Backport tool documentation

* [TSVB] Fix shard failures are not reported elastic#122944

Closes: elastic#122944

* fix PR comments

* Update ui_settings.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 7e1b780)

# Conflicts:
#	src/plugins/vis_types/timeseries/common/constants.ts
#	src/plugins/vis_types/timeseries/kibana.json
#	src/plugins/vis_types/timeseries/public/metrics_type.ts
#	src/plugins/vis_types/timeseries/server/ui_settings.ts
#	x-pack/plugins/infra/server/lib/adapters/metrics/kibana_metrics_adapter.ts
@alexwizp alexwizp added the backport This PR is a backport of another PR label Feb 1, 2022
@alexwizp alexwizp enabled auto-merge (squash) February 1, 2022 10:32
@alexwizp alexwizp disabled auto-merge February 1, 2022 10:33
@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 1, 2022

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibana-ci Feb 1, 2022
@elastic elastic deleted a comment from kibana-ci Feb 1, 2022
@alexwizp alexwizp force-pushed the backport/7.17/pr-123474 branch from 6f2d805 to ff0b882 Compare February 1, 2022 14:47
@flash1293
Copy link
Copy Markdown
Contributor

@alexwizp I looked into the issue with disabled Inspect button and this is happening because there's an await missing here:

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 2, 2022

@ppisljar This PR requires #115336 could you please confirm that we can backport it too into 7.17?

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 3, 2022

This PR can be merged after #124476

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Feb 3, 2022

@elasticmachine merge upstream

@alexwizp alexwizp enabled auto-merge (squash) February 3, 2022 12:12
@alexwizp alexwizp merged commit 8ec3637 into elastic:7.17 Feb 3, 2022
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2819 2822 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 642.1KB 642.2KB +70.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 455.0KB 455.1KB +49.0B
inspector 24.4KB 24.4KB +38.0B
visTypeTimeseries 14.3KB 14.9KB +687.0B
total +774.0B
Unknown metric groups

API count

id before after diff
data 3213 3216 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants