Skip to content

fixing visualize enbeddableRendered event#115336

Merged
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/visualize
Oct 18, 2021
Merged

fixing visualize enbeddableRendered event#115336
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/visualize

Conversation

@ppisljar
Copy link
Copy Markdown
Contributor

@ppisljar ppisljar commented Oct 18, 2021 •
edited
Loading

Summary

visualize default editor was emitting embeddableRendered event too early as it was not awaiting for visualize_embeddable to finish with render method

@ppisljar ppisljar requested a review from a team as a code owner October 18, 2021 11:11
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes review v7.16.0 v8.0.0 labels Oct 18, 2021
@ppisljar ppisljar requested a review from stratoula October 18, 2021 11:12
@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Oct 18, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 18, 2021

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

stratoula
stratoula approved these changes Oct 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I tested it locally and works as expected. Please merge in case of green CI

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 18, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visDefaultEditor 152.7KB 152.7KB +19.0B
visualizations 72.8KB 72.8KB +6.0B
total +25.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit 512b5f8 into elastic:master Oct 18, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 20, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 21, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 22, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@ppisljar ppisljar removed the v7.16.0 label Oct 25, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 25, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 26, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 27, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 28, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 29, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 1, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115336 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This PR does not require backporting label Nov 1, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
@alexwizp alexwizp mentioned this pull request Feb 2, 2022
Merged
alexwizp pushed a commit to alexwizp/kibana that referenced this pull request Feb 3, 2022
@ppisljar @alexwizp
fixing visualize enbeddableRendered event (elastic#115336)
e1aa47e
@alexwizp alexwizp mentioned this pull request Feb 3, 2022
Merged
alexwizp added a commit that referenced this pull request Feb 3, 2022
@alexwizp @ppisljar
fixing visualize enbeddableRendered event (#115336) (#124476)
a53cd71 
Co-authored-by: Peter Pisljar <peter.pisljar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes review Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ppisljar @elasticmachine @kibanamachine @stratoula @spalger