Skip to content

[7.17][SecuritySolution] Fix hidden elements on last page of data grid#123130

Merged
janmonschke merged 3 commits into7.17from
security/fix-datagrid-height-7-17
Jan 18, 2022
Merged

[7.17][SecuritySolution] Fix hidden elements on last page of data grid#123130
janmonschke merged 3 commits into7.17from
security/fix-datagrid-height-7-17

Conversation

@janmonschke
Copy link
Contributor

Note: It appears like the auto-backport of #122781 did not work, so I'm manually opening a PR for 7.17 here.

Summary

There was an issue where when going from a full page to a page with only one item, the height of the table was not tall enough. That meant the single row was hidden. (#122111)

I tried out several ways to prevent this issue but most of them were rather brittle. In the end I decided to add an extra row's height to the hacked height when the actual data is less than the page size.

This PR only targets 8.0 & 7.17 since the height hack will be removed from main soon. (#122755)

New behaviour with single row on the last page:

Screen.Recording.2022-01-12.at.15.29.34.mov

New behaviour with multiple rows on the last page:

Screen.Recording.2022-01-12.at.15.27.16.mov

@janmonschke janmonschke added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.17.0 labels Jan 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 206.0KB 206.0KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@janmonschke janmonschke merged commit aa3ae86 into 7.17 Jan 18, 2022
@janmonschke janmonschke deleted the security/fix-datagrid-height-7-17 branch January 18, 2022 15:13
@janmonschke janmonschke added the backport This PR is a backport of another PR label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants