[8.0/7.17][SecuritySolution] Fix hidden elements on last page of data grid#122781
Merged
janmonschke merged 2 commits into8.0from Jan 14, 2022
Merged
[8.0/7.17][SecuritySolution] Fix hidden elements on last page of data grid#122781janmonschke merged 2 commits into8.0from
janmonschke merged 2 commits into8.0from
Conversation
janmonschke
added
bug
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @janmonschke |
andrew-goldstein
approved these changes
Jan 14, 2022
Contributor
andrew-goldstein
left a comment
andrew-goldstein
left a comment
There was a problem hiding this comment.
Appreciate your effort to explore different solutions, and the simplicity of this temporary fix @janmonschke! 🙏
Desk tested locally at various page heights via the steps in #122111 with the following browsers:
- Chrome
97.0.4692.71 - Firefox
96.0.1 - Safari
15.2
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue where when going from a full page to a page with only one item, the height of the table was not tall enough. That meant the single row was hidden. (#122111)
I tried out several ways to prevent this issue but most of them were rather brittle. In the end I decided to add an extra row's height to the hacked height when the actual data is less than the page size.
This PR only targets
8.0&7.17since the height hack will be removed frommainsoon. (#122755)New behaviour with single row on the last page:
Screen.Recording.2022-01-12.at.15.29.34.mov
New behaviour with multiple rows on the last page:
Screen.Recording.2022-01-12.at.15.27.16.mov