[SecuritySolution] Remove EuiDataGrid height hack#122755
Merged
janmonschke merged 1 commit intomainfrom Jan 12, 2022
Merged
Conversation
With the upgrade to EUI 44.0.0 we no longer need the height hack for the data grid since the issues that were causing wrong heights have been fixed.
janmonschke
added
bug
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @janmonschke |
This was referenced Jan 12, 2022
Contributor
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the upgrade to EUI 44.0.0 we no longer need the height hack for the data grid since the issues that were causing wrong heights have been fixed.
New behaviour:
A single row on the next page:
Screen.Recording.2022-01-12.at.11.01.22.mov
Multiple rows on the next page
Screen.Recording.2022-01-12.at.11.02.17.mov