[Snapshot & Restore] Add component tests for snapshot list search by yuliacech · Pull Request #121537 · elastic/kibana

yuliacech · 2021-12-17T14:59:52Z

Related to Snapshot & Restore tests issue
Follow up work for Snapshots pagination PR.

Summary

This PR adds component integration tests for search functionality in snapshots list.
Note: Instead of asserting on sinon fake server requests, I had to mock useLoadSnapshots because the sinon server doesn't keep track of query params used in the requests (sinon issue I opened for that).

yuliacech · 2021-12-17T15:04:26Z

x-pack/plugins/snapshot_restore/__jest__/client_integration/home.test.ts

-    SNAPSHOT_LIST_MAX_SIZE: 2,
-  };
-});
-


This old mock was used for testing a warning callout about only showing a limited number of snapshots. The warning was removed in #110266

elasticmachine · 2021-12-17T16:52:53Z

Pinging @elastic/kibana-stack-management (Team:Stack Management)

sabarasaba

Nice work adding all these tests @yuliacech! Only left two small comments 🚀

sabarasaba · 2021-12-20T08:25:35Z

x-pack/plugins/snapshot_restore/__jest__/client_integration/snapshot_list.test.tsx

+
+    describe('debounce', () => {
+      test('waits after input to update list params for search', async () => {
+        await setSearchText('snapshot=test_snapshot', false);


To improve readability, wdyt of creating a variable for this?

const ADVANCE_TIME = false; await setSearchText('snapshot=test_snapshot', ADVANCE_TIME);

sabarasaba · 2021-12-20T08:27:33Z

x-pack/plugins/snapshot_restore/__jest__/client_integration/snapshot_list.test.tsx

+    jest.useFakeTimers();
+    const snapshot = fixtures.getSnapshot({
+      repository: REPOSITORY_NAME,
+      snapshot: `a${getRandomString()}`,


is the a prefix on purpose?

Good catch! I copy-pasted this from a different test, not needed here.

yuliacech · 2021-12-20T09:50:17Z

@elasticmachine merge upstream

yuliacech · 2021-12-20T11:08:44Z

Thank you for the review, @sabarasaba! I addressed your comments, could you please have another look?

sabarasaba

Latest changes lgtm 🚀

sebelga · 2021-12-20T11:57:42Z

x-pack/plugins/snapshot_restore/__jest__/client_integration/snapshot_list.test.tsx

+ * &searchField=repository&searchValue=test&searchMatch=must&searchOperator=exact
+ * would be shown as url=/api/snapshot_restore/snapshots is sinon server
+ */
+jest.mock('../../public/application/services/http', () => ({


Just a note. I haven't made an "official" recommendation for it but personally I like that pattern to declare in a single place all the jest mocks for the component integration tests. It has 2 benefits: 1. reduce the size of the test file and 2. avoid declaring multiple times the same jest.mock(...) declaration.

In my last PR you can see

the single jest.mocks.ts file

I import it in a single place in setup_environment.ts which all the test file import

Done. 😊

kibana-ci · 2021-12-20T12:27:31Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`snapshotRestore`	258.5KB	258.6KB	+81.0B

History

💚 Build #13928 succeeded 5784f38

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…astic#121537) * [Snapshot & Restore] Add component tests for snapshot list search * [Snapshot & Restore] Fix term search * [Snapshot & Restore] Add error handling tests * [Snapshot & Restore] Add code review suggestions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…astic#121537) * [Snapshot & Restore] Add component tests for snapshot list search * [Snapshot & Restore] Fix term search * [Snapshot & Restore] Add error handling tests * [Snapshot & Restore] Add code review suggestions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c4585b3)

yuliacech · 2022-02-15T10:22:49Z

Backporting this PR to 8.0 and 7.17 to avoid merge conflicts for backports of #125234 and any further bug fixes.

…21537) (#125617) * [Snapshot & Restore] Add component tests for snapshot list search * [Snapshot & Restore] Fix term search * [Snapshot & Restore] Add error handling tests * [Snapshot & Restore] Add code review suggestions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c4585b3)

…21537) (#125618) * [Snapshot & Restore] Add component tests for snapshot list search * [Snapshot & Restore] Fix term search * [Snapshot & Restore] Add error handling tests * [Snapshot & Restore] Add code review suggestions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c4585b3) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

yuliacech added 3 commits December 17, 2021 13:57

[Snapshot & Restore] Add component tests for snapshot list search

df042e7

[Snapshot & Restore] Fix term search

4fbf2b4

[Snapshot & Restore] Add error handling tests

5784f38

yuliacech commented Dec 17, 2021

View reviewed changes

yuliacech marked this pull request as ready for review December 17, 2021 16:52

yuliacech requested a review from a team as a code owner December 17, 2021 16:52

yuliacech added the v8.1.0 label Dec 17, 2021

yuliacech requested a review from sabarasaba December 17, 2021 16:54

sabarasaba reviewed Dec 20, 2021

View reviewed changes

kibanamachine and others added 2 commits December 20, 2021 04:50

Merge branch 'main' into snapshots_search_tests

519b5ea

[Snapshot & Restore] Add code review suggestions

c31a293

yuliacech requested a review from sabarasaba December 20, 2021 11:08

sabarasaba approved these changes Dec 20, 2021

View reviewed changes

sebelga reviewed Dec 20, 2021

View reviewed changes

yuliacech merged commit c4585b3 into elastic:main Dec 20, 2021

kibanamachine added the backport:skip This PR does not require backporting label Dec 20, 2021

yuliacech mentioned this pull request Feb 15, 2022

[8.0] [Snapshot & Restore] Add component tests for snapshot list search (#121537) #125617

Merged

yuliacech mentioned this pull request Feb 15, 2022

[7.17] [Snapshot & Restore] Add component tests for snapshot list search (#121537) #125618

Merged

yuliacech added v8.0.1 v7.17.1 labels Feb 15, 2022

yuliacech deleted the snapshots_search_tests branch March 7, 2022 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snapshot & Restore] Add component tests for snapshot list search#121537

[Snapshot & Restore] Add component tests for snapshot list search#121537
yuliacech merged 5 commits intoelastic:mainfrom
yuliacech:snapshots_search_tests

yuliacech commented Dec 17, 2021

Uh oh!

yuliacech Dec 17, 2021

Uh oh!

elasticmachine commented Dec 17, 2021

Uh oh!

sabarasaba left a comment

Uh oh!

sabarasaba Dec 20, 2021

Uh oh!

sabarasaba Dec 20, 2021

Uh oh!

yuliacech Dec 20, 2021

Uh oh!

yuliacech commented Dec 20, 2021

Uh oh!

yuliacech commented Dec 20, 2021

Uh oh!

sabarasaba left a comment

Uh oh!

sebelga Dec 20, 2021 •

edited

Loading

Uh oh!

kibana-ci commented Dec 20, 2021

Uh oh!

yuliacech commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

yuliacech commented Dec 17, 2021

Summary

Uh oh!

yuliacech Dec 17, 2021

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 17, 2021

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

sabarasaba Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

sabarasaba Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

yuliacech Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

yuliacech commented Dec 20, 2021

Uh oh!

yuliacech commented Dec 20, 2021

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

sebelga Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Dec 20, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

yuliacech commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sebelga Dec 20, 2021 •

edited

Loading