Skip to content

[Snapshot & Restore] Fix date parsing in the search bar#125234

Merged
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:snapshots_fix_date_parsing
Feb 14, 2022
Merged

[Snapshot & Restore] Fix date parsing in the search bar#125234
yuliacech merged 2 commits intoelastic:mainfrom
yuliacech:snapshots_fix_date_parsing

Conversation

@yuliacech
Copy link
Copy Markdown
Contributor

Fixes #124795

Summary

This PR fixes an issue when a date was typed into the search bar of the snapshots list. The parsing error was caused by the missing search schema when using Query.parse.

Checklist

Release Note

The search bar in the snapshots list of the Snapshot & Restore app can be used with date strings again.

@yuliacech yuliacech added release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI v8.1.0 v8.2.0 v8.0.1 v7.17.1 labels Feb 10, 2022
@yuliacech yuliacech requested a review from a team as a code owner February 10, 2022 13:09
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech requested a review from sebelga February 10, 2022 15:29
@yuliacech
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and works as expected 👍 Thanks for fixing this @yuliacech !

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 258.3KB 258.3KB +18.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech
Copy link
Copy Markdown
Contributor Author

Thanks a lot for the review, @sebelga!

@yuliacech yuliacech added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 14, 2022
@yuliacech yuliacech merged commit c14173c into elastic:main Feb 14, 2022
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.1
8.0 Backport failed because of merge conflicts
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 125234

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 14, 2022
…25511)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
yuliacech added a commit to yuliacech/kibana that referenced this pull request Feb 15, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)
yuliacech added a commit that referenced this pull request Feb 15, 2022
…25637)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)
yuliacech added a commit to yuliacech/kibana that referenced this pull request Feb 15, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)
yuliacech added a commit that referenced this pull request Feb 15, 2022
…25669)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit c14173c)
@yuliacech yuliacech deleted the snapshots_fix_date_parsing branch March 7, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.17.1 v8.0.1 v8.1.0 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search date in snapshots page crashes

5 participants