-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Snapshot & Restore] Add component tests for snapshot list search #121537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
df042e7
[Snapshot & Restore] Add component tests for snapshot list search
yuliacech 4fbf2b4
[Snapshot & Restore] Fix term search
yuliacech 5784f38
[Snapshot & Restore] Add error handling tests
yuliacech 519b5ea
Merge branch 'main' into snapshots_search_tests
kibanamachine c31a293
[Snapshot & Restore] Add code review suggestions
yuliacech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
x-pack/plugins/snapshot_restore/__jest__/client_integration/helpers/snapshot_list.helpers.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { act } from 'react-dom/test-utils'; | ||
| import { TestBedConfig, registerTestBed, TestBed } from '@kbn/test/jest'; | ||
|
|
||
| import { BASE_PATH } from '../../../public/application/constants'; | ||
| import { SnapshotList } from '../../../public/application/sections/home/snapshot_list'; | ||
| import { WithAppDependencies } from './setup_environment'; | ||
|
|
||
| const getTestBedConfig = (query?: string): TestBedConfig => ({ | ||
| memoryRouter: { | ||
| initialEntries: [`${BASE_PATH}/snapshots${query ?? ''}`], | ||
| componentRoutePath: `${BASE_PATH}/snapshots/:repositoryName?/:snapshotId*`, | ||
| }, | ||
| }); | ||
|
|
||
| const initTestBed = (query?: string) => | ||
| registerTestBed(WithAppDependencies(SnapshotList), getTestBedConfig(query))(); | ||
|
|
||
| export interface SnapshotListTestBed extends TestBed { | ||
| actions: { | ||
| setSearchText: (value: string, advanceTime?: boolean) => void; | ||
| searchErrorExists: () => boolean; | ||
| getSearchErrorText: () => string; | ||
| }; | ||
| } | ||
|
|
||
| const searchBarSelector = 'snapshotListSearch'; | ||
| const searchErrorSelector = 'snapshotListSearchError'; | ||
|
|
||
| export const setup = async (query?: string): Promise<SnapshotListTestBed> => { | ||
| const testBed = await initTestBed(query); | ||
| const { form, component, find, exists } = testBed; | ||
|
|
||
| const setSearchText = async (value: string, advanceTime = true) => { | ||
| await act(async () => { | ||
| form.setInputValue(searchBarSelector, value); | ||
| }); | ||
| component.update(); | ||
| if (advanceTime) { | ||
| await act(async () => { | ||
| jest.advanceTimersByTime(500); | ||
| }); | ||
| component.update(); | ||
| } | ||
| }; | ||
|
|
||
| const searchErrorExists = (): boolean => { | ||
| return exists(searchErrorSelector); | ||
| }; | ||
|
|
||
| const getSearchErrorText = (): string => { | ||
| return find(searchErrorSelector).text(); | ||
| }; | ||
|
|
||
| return { | ||
| ...testBed, | ||
| actions: { | ||
| setSearchText, | ||
| searchErrorExists, | ||
| getSearchErrorText, | ||
| }, | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This old mock was used for testing a warning callout about only showing a limited number of snapshots. The warning was removed in #110266