Upgrade Typescript to 4.3.5#104470
Merged
tylersmalley merged 117 commits intoelastic:mainfrom Dec 3, 2021
Merged
Conversation
Member
Author
|
@dgieselaar mind taking a look at this? Looks like you added last week. |
Contributor
|
@tylersmalley fixed the errors in |
Member
Author
|
@elasticmachine merge upstream |
1 similar comment
Contributor
|
@elasticmachine merge upstream |
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Member
Author
|
Someone from @elastic/kibana-core mind taking a look at these failures from bootstrap/build_ts_refs? view errors |
mshustov
reviewed
Aug 13, 2021
| * @public | ||
| */ | ||
| export type ResponseHeaders = | ||
| | Record<KnownHeaders, string | string[]> |
Contributor
There was a problem hiding this comment.
KnownHeaders helper is broken, I didn't manage to fix it quickly. Its only purpose is to improve autocomplete in IDE, so I removed it for time being. I will fix it later.
Member
There was a problem hiding this comment.
Ran into the same issue in Fleet. Just replacing with a string[] for now.
Contributor
|
@tylersmalley fixed the Core errors |
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Member
Author
|
@elastic/kibana-app can you please assist with the following errors in your plugins while bootstrapping? Thanks view errors |
Member
Author
|
@elastic/kibana-app-services can you please assist with the following errors in your plugins while bootstrapping? Thanks view errors |
Member
Author
|
@elastic/kibana-presentation can you please assist with the following errors in your plugins while bootstrapping? Thanks view errors |
Member
Author
|
@elastic/security-solution can you please assist with the following errors in your plugins while bootstrapping? Thanks view errors |
Member
Author
|
view errors |
Member
Author
|
view errors |
JasonStoltz
approved these changes
Dec 2, 2021
jbudz
approved these changes
Dec 2, 2021
vadimkibana
approved these changes
Dec 2, 2021
academo
approved these changes
Dec 2, 2021
weltenwort
approved these changes
Dec 2, 2021
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
infra plugin changes LGTM, thank you
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
stephmilovic
approved these changes
Dec 2, 2021
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM for threat hunting! thank you
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
kertal
approved these changes
Dec 2, 2021
justinkambic
approved these changes
Dec 2, 2021
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Uptime changes LGTM.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
dgieselaar
approved these changes
Dec 2, 2021
Contributor
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
Stuff breaks, but we'll follow up separately in #120272
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
Dec 2, 2021
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Stack Management changes LGTM:
- Console change is a code style change
- Mappings editor change removes unreachable code branch
- Ingest Pipelines change doesn't affect behavior (tested locally to verify)
- Upgrade Assistant test change retains coverage of behavior intended to be tested
jportner
approved these changes
Dec 3, 2021
Contributor
jportner
left a comment
jportner
left a comment
There was a problem hiding this comment.
Thanks for addressing Thomas's comments!
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Mikhail Shustov <restrry@gmail.com> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kyle Pollich <kpollich1@gmail.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co> Co-authored-by: Candace Park <candace.park@elastic.co> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: spalger <spencer@elastic.co>
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
May 31, 2023
Co-authored-by: Mikhail Shustov <restrry@gmail.com> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kyle Pollich <kpollich1@gmail.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co> Co-authored-by: Candace Park <candace.park@elastic.co> Co-authored-by: Brian Seeders <brian.seeders@elastic.co> Co-authored-by: spalger <spencer@elastic.co> (cherry picked from commit 92a8636) # Conflicts: # package.json # packages/kbn-alerts/BUILD.bazel # packages/kbn-babel-register/BUILD.bazel # packages/kbn-babel-register/tsconfig.json # packages/kbn-pm/dist/index.js # packages/kbn-test/src/jest/run.ts # src/core/public/public.api.md # src/core/public/theme/theme_service.ts # src/core/types/elasticsearch/search.ts # src/plugins/discover/public/build_services.ts # src/plugins/presentation_util/public/components/controls/control_group/embeddable/control_group_container_factory.ts # x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts # x-pack/plugins/apm/server/lib/helpers/setup_request.ts # x-pack/plugins/apm/server/lib/services/get_service_error_groups/get_service_error_group_main_statistics.ts # x-pack/plugins/apm/server/lib/transaction_groups/get_transaction_group_stats.ts # x-pack/plugins/apm/server/types.ts # x-pack/plugins/data_visualizer/public/application/index_data_visualizer/utils/saved_search_utils.test.ts # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_details_flyout/accordion_list.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.test.tsx # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/crawl_requests_table.tsx # x-pack/plugins/infra/public/alerting/log_threshold/components/expression_editor/criterion.tsx # x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_create/pipelines_create.tsx # x-pack/plugins/rule_registry/server/utils/create_lifecycle_rule_type.test.ts # x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.test.tsx # x-pack/plugins/security_solution/server/lib/detection_engine/routes/signals/query_signals_route.test.ts # x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.test.ts # x-pack/plugins/uptime/public/state/effects/journey.ts # x-pack/plugins/uptime/server/lib/requests/get_ping_histogram.ts # yarn.lock
mistic
added a commit
that referenced
this pull request
Jun 1, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [Upgrade Typescript to 4.3.5 (#104470)](#104470) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tyler Smalley","email":"tyler.smalley@elastic.co"},"sourceCommit":{"committedDate":"2021-12-03T00:27:41Z","message":"Upgrade Typescript to 4.3.5 (#104470)\n\nCo-authored-by: Mikhail Shustov <restrry@gmail.com>\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>\r\nCo-authored-by: CJ Cenizal <cj@cenizal.com>\r\nCo-authored-by: Justin Kambic <justin.kambic@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Kyle Pollich <kpollich1@gmail.com>\r\nCo-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>\r\nCo-authored-by: Kevin Qualters <kevin.qualters@elastic.co>\r\nCo-authored-by: Candace Park <candace.park@elastic.co>\r\nCo-authored-by: Brian Seeders <brian.seeders@elastic.co>\r\nCo-authored-by: spalger <spencer@elastic.co>","sha":"92a8636f0ff63ab072527574e96e6616327b2ea4","branchLabelMapping":{"^v8.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Feature:Embedding","Team:APM","Feature:ExpressionLanguage","Team:uptime","release_note:skip","backport:skip","Feature:Drilldowns","Team:Fleet","v8.1.0","ci:all-cypress-suites"],"number":104470,"url":"https://github.com/elastic/kibana/pull/104470","mergeCommit":{"message":"Upgrade Typescript to 4.3.5 (#104470)\n\nCo-authored-by: Mikhail Shustov <restrry@gmail.com>\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>\r\nCo-authored-by: CJ Cenizal <cj@cenizal.com>\r\nCo-authored-by: Justin Kambic <justin.kambic@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Kyle Pollich <kpollich1@gmail.com>\r\nCo-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>\r\nCo-authored-by: Kevin Qualters <kevin.qualters@elastic.co>\r\nCo-authored-by: Candace Park <candace.park@elastic.co>\r\nCo-authored-by: Brian Seeders <brian.seeders@elastic.co>\r\nCo-authored-by: spalger <spencer@elastic.co>","sha":"92a8636f0ff63ab072527574e96e6616327b2ea4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.1.0","labelRegex":"^v8.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/104470","number":104470,"mergeCommit":{"message":"Upgrade Typescript to 4.3.5 (#104470)\n\nCo-authored-by: Mikhail Shustov <restrry@gmail.com>\r\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>\r\nCo-authored-by: CJ Cenizal <cj@cenizal.com>\r\nCo-authored-by: Justin Kambic <justin.kambic@elastic.co>\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>\r\nCo-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>\r\nCo-authored-by: Kyle Pollich <kpollich1@gmail.com>\r\nCo-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>\r\nCo-authored-by: Kevin Qualters <kevin.qualters@elastic.co>\r\nCo-authored-by: Candace Park <candace.park@elastic.co>\r\nCo-authored-by: Brian Seeders <brian.seeders@elastic.co>\r\nCo-authored-by: spalger <spencer@elastic.co>","sha":"92a8636f0ff63ab072527574e96e6616327b2ea4"}}]}] BACKPORT--> --------- Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100563
Blockers:
PRs:
Release Notes:
microsoft/TypeScript#43194
TODO after merge: