Skip to content

[Index Management] Forward port of the fix for indices table test#115933

Merged
yuliacech merged 1 commit intoelastic:masterfrom
yuliacech:indices_test_forward_port
Oct 21, 2021
Merged

[Index Management] Forward port of the fix for indices table test#115933
yuliacech merged 1 commit intoelastic:masterfrom
yuliacech:indices_test_forward_port

Conversation

@yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Oct 21, 2021

Summary

This PR added specific data-test-subj to the context buttons in the indices table to make testing easier, but the backport to 7.16 was failing because of the differences between 8.0 and 7.16 in how indices are displayed. I added additional code to fix the failing tests and now this needs to be forward ported to master.

@yuliacech yuliacech added Feature:Index Management Index and index templates UI technical debt Improvement of the software architecture and operational architecture v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes labels Oct 21, 2021
@yuliacech yuliacech requested a review from a team as a code owner October 21, 2021 12:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 21, 2021

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech yuliacech requested a review from sebelga October 21, 2021 12:59
sebelga
sebelga approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍, thanks for aligning both branches!

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 21, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit 31e7428 into elastic:master Oct 21, 2021
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
@yuliacech @shivindera
[Index Management] Forward port of the fix for indices table test in …
4daf01f 
…7.16 (elastic#115933)
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115933 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2021
@yuliacech yuliacech removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2021
@yuliacech yuliacech deleted the indices_test_forward_port branch October 25, 2021 18:38
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 26, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 26, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115933 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115933 or prevent reminders by adding the backport:skip label.

@yuliacech yuliacech added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebelga sebelga sebelga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// technical debt Improvement of the software architecture and operational architecture v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuliacech @elasticmachine @kibanamachine @sebelga