[Index Management] Added specific data-test-subj values to index context menu buttons#114900
Merged
yuliacech merged 1 commit intoelastic:masterfrom Oct 14, 2021
Merged
Conversation
yuliacech
added
Feature:Index Management
Contributor
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
cuff-links
approved these changes
Oct 14, 2021
Contributor
cuff-links
left a comment
cuff-links
left a comment
There was a problem hiding this comment.
I reviewed the changes and this will help the tests tremendously. Ran locally. Works great. Will merge this change into the existing PRs once merged.
sabarasaba
approved these changes
Oct 14, 2021
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
so much better! thanks @yuliacech !
yuliacech
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 14, 2021
…mple/introduce-baseline-tests * 'master' of github.com:elastic/kibana: (55 commits) [Fleet] Improve Functionality around Managed Package Policies (elastic#114526) cleanup (elastic#114902) remove stray semicolon (elastic#114969) [Security Solution] Edit host isolation exception IP UI (elastic#114279) [ML] APM Correlations: Round duration values to be used in range aggregations. (elastic#114833) [Index Management] Added `data-test-subj` values to the index context menu buttons (elastic#114900) [Stack monitoring] Fix logstash functional tests for react (elastic#114819) Implement hybrid approach to writing rule execution event logs (elastic#114852) [Detection Rules] Add 7.16 rules (elastic#114939) Fixing exceptions export format (elastic#114920) Clean up inaccurate comments (elastic#114935) chore(NA): fixes a typo on persist_bazel_cache.sh comment (elastic#114943) [ci] Fixes Bazel cache writes (elastic#114915) fix package.json: (elastic#114936) [Controls] Redux Toolkit and Embeddable Redux Wrapper (elastic#114371) [APM] Fixes incorrect index config names (elastic#114901) (elastic#114904) [Workplace Search] Fix button order and remove extra source name label (elastic#114899) [Actions] Fixed actions telemetry for multiple namespaces usage (elastic#114748) docs: fix config names (elastic#114903) Update kibana to EMS 7.16 (elastic#114865) ...
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
tylersmalley
pushed a commit
that referenced
this pull request
Oct 21, 2021
…ontext menu buttons (#114900) (#114959) * [Index Management] Added `data-test-subj` values to the index context menu buttons (#114900) * Fixed test as indices list is different in 7.x * [Index Management] Fixed indices list test for 7.x Indices list are different on 7.x and 8.0, that is why the test was failing in the backport branch * [Index Management] Fixed indices list test for 7.x Updated the snapshot after the test has been fixed for 7.x Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds specific
data-test-subjvalues to index context menu buttons to make it easier to test index context menu actions. Follow up to @cuff-links tests PR.