Skip to content

[Index Management] Forward port of the fix for indices table test #115933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuliacech merged 1 commit into from
Oct 21, 2021
Merged

[Index Management] Forward port of the fix for indices table test #115933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/__jest__/components/__snapshots__/index_table.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions x-pack/plugins/index_management/__jest__/components/index_table.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ const snapshot = (rendered) => {
expect(rendered).toMatchSnapshot();
};

const names = (rendered) => {
return findTestSubject(rendered, 'indexTableIndexNameLink');
};

const namesText = (rendered) => {
return names(rendered).map((button) => button.text());
};

const openMenuAndClickButton = (rendered, rowIndex, buttonSelector) => {
// Select a row.
const checkboxes = findTestSubject(rendered, 'indexTableRowCheckbox');
Expand All @@ -111,7 +119,8 @@ const testEditor = (rendered, buttonSelector, rowIndex = 0) => {
snapshot(findTestSubject(rendered, 'detailPanelTabSelected').text());
};

const testAction = (rendered, buttonSelector, rowIndex = 0) => {
const testAction = (rendered, buttonSelector, indexName = 'testy0') => {
const rowIndex = namesText(rendered).indexOf(indexName);
// This is leaking some implementation details about how Redux works. Not sure exactly what's going on
// but it looks like we're aware of how many Redux actions are dispatched in response to user interaction,
// so we "time" our assertion based on how many Redux actions we observe. This is brittle because it
Expand All @@ -132,14 +141,6 @@ const testAction = (rendered, buttonSelector, rowIndex = 0) => {
snapshot(status(rendered, rowIndex));
};

const names = (rendered) => {
return findTestSubject(rendered, 'indexTableIndexNameLink');
};

const namesText = (rendered) => {
return names(rendered).map((button) => button.text());
};

const getActionMenuButtons = (rendered) => {
return findTestSubject(rendered, 'indexContextMenu')
.find('button')
Expand Down Expand Up @@ -487,24 +488,23 @@ describe('index table', () => {
});

test('open index button works from context menu', async () => {
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();

const modifiedIndices = indices.map((index) => {
return {
...index,
status: index.name === 'testy1' ? 'open' : index.status,
status: index.name === 'testy1' ? 'closed' : index.status,
};
});

server.respondWith(`${API_BASE_PATH}/indices/reload`, [
server.respondWith(`${API_BASE_PATH}/indices`, [
200,
{ 'Content-Type': 'application/json' },
JSON.stringify(modifiedIndices),
]);

testAction(rendered, 'openIndexMenuButton', 1);
const rendered = mountWithIntl(component);
await runAllPromises();
rendered.update();
testAction(rendered, 'openIndexMenuButton', 'testy1');
});

test('show settings button works from context menu', async () => {
Expand Down