[Fleet] Add Integration Policy Page Improvements by hop-dev · Pull Request #114556 · elastic/kibana

hop-dev · 2021-10-11T19:29:13Z

Summary

I am breaking #112626 into smaller PRs to make it more reviewable.

This PR has the following changes:

Policy Page

instead of showing 0 agents, show add agents link
Change text above agent count to just "agents"
add showAddAgentHelp=true query param to control popover visibility (this will be used in a later PR)

Figma designs https://www.figma.com/file/RVYNk5W3gyJdWOGDj8ixPH/Fleet?node-id=1486%3A279812

Package policies page

add showAddAgentHelpForPolicyId=1234 query param to show help popover for a given policy

Figma designs: https://www.figma.com/file/RVYNk5W3gyJdWOGDj8ixPH/Fleet?node-id=1546%3A291020

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
[] Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx

elasticmachine · 2021-10-12T12:28:15Z

Pinging @elastic/fleet (Team:Fleet)

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/index.tsx

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/index.tsx

dborodyansky · 2021-10-12T16:16:28Z

Great call @snide. I referenced EuiTour in the design doc, but seem to have used incorrect component in Figma design. (Sidenote: I don't think we have EuiTour in Figma library yet)

@hop-dev The version Dave presented with footer button would be preferred IMO. Thank you

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx

Co-authored-by: Dave Snider <dave.snider@gmail.com>

hop-dev · 2021-10-12T19:40:42Z

@elasticmachine merge upstream

kibanamachine · 2021-10-12T22:42:04Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	578	579	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	626.0KB	628.1KB	+2.1KB

History

💔 Build #160196 failed 4a35649
💔 Build #160131 failed 0762193
💔 Build #160179 failed 0101088
💚 Build #160116 succeeded 630cc86
💚 Build #159874 succeeded f75d850

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

nchaulet

Tested locally and looks good to me 🚀

snide

My comments were all resolved. LGTM.

* Show add agent link instead of 0 agents * Add popover * open and close popover * fill button * add popover to agent cell * PR feedback * only add offset to props if it's provided * make code clearer * Update x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx Co-authored-by: Dave Snider <dave.snider@gmail.com> * remove unused import * whitespace Co-authored-by: Dave Snider <dave.snider@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-13T08:13:03Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Show add agent link instead of 0 agents * Add popover * open and close popover * fill button * add popover to agent cell * PR feedback * only add offset to props if it's provided * make code clearer * Update x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx Co-authored-by: Dave Snider <dave.snider@gmail.com> * remove unused import * whitespace Co-authored-by: Dave Snider <dave.snider@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co> Co-authored-by: Dave Snider <dave.snider@gmail.com>

…ide-users-to-saving-ux * 'master' of github.com:elastic/kibana: (133 commits) [DOCS] Indicate reports are a subscription feature (elastic#114653) Update namespace for indices (elastic#114612) [DOCS] Adds Logstash pipeline settings (elastic#114648) Bump EPR snapshot version used for tests (elastic#114529) [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291) skip flaky suite (elastic#68400) [Visualizations] fix usage of optional dependencies (elastic#114286) [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454) [fleet] Add Integration Preference selector (elastic#114432) [Reporting] Add new `data-render-error` attribute (elastic#114472) Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316) [data views] add getDefaultDataView method (elastic#113891) [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126) [fleet] Tweak Header UI (elastic#114704) [APM] Filter on tx metrics for instance stats (elastic#114758) [APM] Fix typo in linting docs (elastic#114764) [Discover] Removing SavedObject usage for savedSearch (elastic#112983) [Fleet] Add Integration Policy Page Improvements (elastic#114556) [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270) [Security Solution][Endpoint] Host Isolation API changes (elastic#113621) ...

hop-dev added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 11, 2021

hop-dev self-assigned this Oct 11, 2021

hop-dev commented Oct 11, 2021

View reviewed changes

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx Outdated Show resolved Hide resolved

hop-dev added 5 commits October 12, 2021 10:54

Show add agent link instead of 0 agents

77a3ff7

Add popover

4ed898a

open and close popover

f0ec537

fill button

99a27ee

add popover to agent cell

f75d850

hop-dev force-pushed the 112626-policy-page-changes branch from 07734a5 to f75d850 Compare October 12, 2021 09:54

hop-dev marked this pull request as ready for review October 12, 2021 12:28

hop-dev requested a review from a team as a code owner October 12, 2021 12:28

nchaulet reviewed Oct 12, 2021

View reviewed changes

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/index.tsx Outdated Show resolved Hide resolved

criamico reviewed Oct 12, 2021

View reviewed changes

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/index.tsx Outdated Show resolved Hide resolved

snide reviewed Oct 12, 2021

View reviewed changes

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx Outdated Show resolved Hide resolved

juliaElastic reviewed Oct 12, 2021

View reviewed changes

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/index.tsx Outdated Show resolved Hide resolved

hop-dev added 3 commits October 12, 2021 18:03

PR feedback

630cc86

only add offset to props if it's provided

6b739f7

make code clearer

0762193

hop-dev requested review from criamico, juliaElastic, nchaulet and snide October 12, 2021 17:31

snide reviewed Oct 12, 2021

View reviewed changes

x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/fleet/public/components/add_agent_help_popover.tsx

0101088

Co-authored-by: Dave Snider <dave.snider@gmail.com>

remove unused import

6e32df5

kibanamachine and others added 2 commits October 12, 2021 15:40

Merge branch 'master' into 112626-policy-page-changes

4a35649

whitespace

68c36ac

nchaulet approved these changes Oct 12, 2021

View reviewed changes

snide approved these changes Oct 13, 2021

View reviewed changes

hop-dev merged commit 62d39cc into elastic:master Oct 13, 2021

hop-dev deleted the 112626-policy-page-changes branch October 13, 2021 08:10

kibanamachine mentioned this pull request Oct 13, 2021

[7.x] [Fleet] Add Integration Policy Page Improvements (#114556) #114762

Merged

danielkhan mentioned this pull request Nov 1, 2021

[Fleet] Add agent help popover stays when button is clicked #117044

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Add Integration Policy Page Improvements#114556

[Fleet] Add Integration Policy Page Improvements#114556
hop-dev merged 12 commits intoelastic:masterfrom
hop-dev:112626-policy-page-changes

hop-dev commented Oct 11, 2021 •

edited

Loading

Uh oh!

Uh oh!

elasticmachine commented Oct 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dborodyansky commented Oct 12, 2021

Uh oh!

Uh oh!

hop-dev commented Oct 12, 2021

Uh oh!

kibanamachine commented Oct 12, 2021

Uh oh!

nchaulet left a comment

Uh oh!

snide left a comment

Uh oh!

kibanamachine commented Oct 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

hop-dev commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Policy Page

Package policies page

Checklist

Uh oh!

Uh oh!

elasticmachine commented Oct 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dborodyansky commented Oct 12, 2021

Uh oh!

Uh oh!

hop-dev commented Oct 12, 2021

Uh oh!

kibanamachine commented Oct 12, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

nchaulet left a comment

Choose a reason for hiding this comment

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 13, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hop-dev commented Oct 11, 2021 •

edited

Loading