[Security Solution] [Endpoint] Fleet summary card adjustments#114291
Merged
dasansol92 merged 5 commits intoelastic:masterfrom Oct 13, 2021
Merged
Conversation
dasansol92
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
Contributor
Author
|
@elasticmachine merge upstream |
academo
approved these changes
Oct 13, 2021
Contributor
academo
left a comment
academo
left a comment
There was a problem hiding this comment.
You get a 🐑 of approval.
Suggestion: is there an unit test you can add to cover the isSmall case?
Contributor
Author
|
@academo @paul-tavares Did a small refactor in fleet-trusted-apps-card component |
academo
approved these changes
Oct 13, 2021
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| `; | ||
|
|
||
| export const StyledEuiFlexItem = styled(EuiFlexItem)` | ||
| flex-direction: row-reverse; |
Contributor
There was a problem hiding this comment.
I thought that EuiFlexItem allowed you to do this via a prop already
Contributor
Author
There was a problem hiding this comment.
Unfortunately not, only for the EuiFlexGroup one.
paul-tavares
approved these changes
Oct 13, 2021
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
Small comment, but 👍 🚢
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2021
…c#114291) * Fix API call and refactor component to show different summary when size is small * Refactored fleet trusted app card with new m design * Removed unused code * fix ts error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 13, 2021
…ide-users-to-saving-ux * 'master' of github.com:elastic/kibana: (133 commits) [DOCS] Indicate reports are a subscription feature (elastic#114653) Update namespace for indices (elastic#114612) [DOCS] Adds Logstash pipeline settings (elastic#114648) Bump EPR snapshot version used for tests (elastic#114529) [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291) skip flaky suite (elastic#68400) [Visualizations] fix usage of optional dependencies (elastic#114286) [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454) [fleet] Add Integration Preference selector (elastic#114432) [Reporting] Add new `data-render-error` attribute (elastic#114472) Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316) [data views] add getDefaultDataView method (elastic#113891) [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126) [fleet] Tweak Header UI (elastic#114704) [APM] Filter on tx metrics for instance stats (elastic#114758) [APM] Fix typo in linting docs (elastic#114764) [Discover] Removing SavedObject usage for savedSearch (elastic#112983) [Fleet] Add Integration Policy Page Improvements (elastic#114556) [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270) [Security Solution][Endpoint] Host Isolation API changes (elastic#113621) ...
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2021
… (#114826) * Fix API call and refactor component to show different summary when size is small * Refactored fleet trusted app card with new m design * Removed unused code * fix ts error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: David Sánchez <davidsansol92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For maintainers