Skip to content

Update namespace for indices#114612

Merged
gbamparop merged 5 commits intoelastic:masterfrom
gbamparop:apm-update-configuration-settings
Oct 13, 2021
Merged

Update namespace for indices#114612
gbamparop merged 5 commits intoelastic:masterfrom
gbamparop:apm-update-configuration-settings

Conversation

@gbamparop
Copy link
Copy Markdown
Contributor

@gbamparop gbamparop commented Oct 12, 2021 •
edited
Loading

Summary

Update namespace for indices in APM configuration settings.

Closes #114611.

@gbamparop gbamparop added release_note:fix Team:APM - DEPRECATED Use Team:obs-ux-infra_services. auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 12, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 12, 2021

Pinging @elastic/apm-ui (Team:apm)

@gbamparop gbamparop requested a review from sorenlouv October 12, 2021 10:21
sorenlouv
sorenlouv approved these changes Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please wait merging this until #113364 is merged

sorenlouv
sorenlouv reviewed Oct 12, 2021
View reviewed changes
smith
smith requested changes Oct 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the labels here in this PR, since that's what you see when you go to the settings: https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx#L31-L71

@sorenlouv
Copy link
Copy Markdown
Member

sorenlouv commented Oct 12, 2021

We should also update the labels here in this PR, since that's what you see when you go to the settings: master/x-pack/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx#L31-L71

That's what @ogupte is fixing in #113364

@ogupte
Copy link
Copy Markdown
Contributor

ogupte commented Oct 13, 2021

@gbamparop see the latest changes in my PR (#113364)

apm_oss.errorIndices -> xpack.apm.indices.error
apm_oss.metricsIndices -> xpack.apm.indices.metric
apm_oss.onboardingIndices -> xpack.apm.indices.onboarding
apm_oss.sourcemapIndices -> xpack.apm.indices.sourcemap
apm_oss.spanIndices -> xpack.apm.indices.span
apm_oss.transactionIndices -> xpack.apm.indices.transaction

These config changes are now final.

@ogupte ogupte enabled auto-merge (squash) October 13, 2021 05:24
@ogupte ogupte disabled auto-merge October 13, 2021 05:24
@gbamparop
Copy link
Copy Markdown
Contributor Author

gbamparop commented Oct 13, 2021

Thanks @ogupte. I have updated the namespaces

@gbamparop gbamparop requested review from a team October 13, 2021 09:26
@gbamparop gbamparop requested review from a team as code owners October 13, 2021 09:26
@gbamparop gbamparop requested review from smith and sorenlouv and removed request for a team, joeypoon, parkiino and vigneshshanmugam October 13, 2021 09:30
@gbamparop gbamparop merged commit 767f007 into elastic:master Oct 13, 2021
@gbamparop gbamparop deleted the apm-update-configuration-settings branch October 13, 2021 14:57
@kibanamachine kibanamachine mentioned this pull request Oct 13, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 13, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

bmorelli25
bmorelli25 reviewed Oct 13, 2021
View reviewed changes
docs/apm/troubleshooting.asciidoc
If the Elasticsearch index template has already been successfully loaded to the index,
you can customize the indices that the APM app uses to display data.
Navigate to *APM* > *Settings* > *Indices*, and change all `apm_oss.*Pattern` values to
Navigate to *APM* > *Settings* > *Indices*, and change all `xpack.apm.*Pattern` values to
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still figuring out my way around this change. Shouldn't this be xpack.apm.indices.*?

Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the fix to #114903.

Copy link
Copy Markdown
Contributor Author

@gbamparop gbamparop Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this should have been removed instead, good spot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@smith smith smith approved these changes

@sorenlouv sorenlouv Awaiting requested review from sorenlouv

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Update namespaces for APM configuration settings

7 participants

@gbamparop @elasticmachine @sorenlouv @ogupte @kibanamachine @smith @bmorelli25