[ts] Check .d.ts files for all projects in typeCheck#114295
Merged
spalger merged 6 commits intoelastic:masterfrom Oct 13, 2021
Merged
[ts] Check .d.ts files for all projects in typeCheck#114295spalger merged 6 commits intoelastic:masterfrom
spalger merged 6 commits intoelastic:masterfrom
Conversation
spalger
force-pushed
the
implement/check-lib-files-on-ci
branch
from
fdd1eb0 to
784b4fa
Compare
spalger
force-pushed
the
implement/check-lib-files-on-ci
branch
4 times, most recently
from
c86bc9d to
3837cab
Compare
spalger
changed the title
spalger
added
release_note:skip
spalger
force-pushed
the
implement/check-lib-files-on-ci
branch
from
3837cab to
3a4a992
Compare
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Oct 12, 2021
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2021
* enable --skip-lib-check for all projects in typeCheck and fix existing issues * fix graph types * transpile TS to ES2019, but not all the way back to es5 Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2021
* enable --skip-lib-check for all projects in typeCheck and fix existing issues * fix graph types * transpile TS to ES2019, but not all the way back to es5 Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #107981 I stopped composite projects from being executed with
--skip-lib-check=falseby only testing types in thebuild ts refsstep when usingnode scripts/type_check. This PR reverts that change and (along with #114342) fixes the newly broken types since this change was merged.[skip ci]