Merged
Conversation
spalger
added
Team:Monitoring
spalger
force-pushed
the
fix/monitoring-types
branch
from
3dcdba5 to
c96fd7c
Compare
spalger
force-pushed
the
fix/monitoring-types
branch
from
c96fd7c to
34f87ba
Compare
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
matschaffer
approved these changes
Oct 11, 2021
Contributor
matschaffer
left a comment
matschaffer
left a comment
There was a problem hiding this comment.
All looks reasonable to me. I'm sure if this causes issues with the angular removal work we'll notice fairly soon since we've started on sorting out the functional tests last week.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
This was referenced Oct 11, 2021
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 11, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/application/setup_mode/setup_mode_renderer.d.ts
spalger
added a commit
that referenced
this pull request
Oct 12, 2021
* [monitoring] fixup types (#114342) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/public/application/setup_mode/setup_mode_renderer.d.ts * fix import Co-authored-by: spalger <spalger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #114295 I'm working on re-enabling type checking for .d.ts files, which was disabled previously but folks have taken issue with this because we're apparently still using
.d.tsfiles in a large number of places. Monitoring uses.d.tsfiles in a large number of places to deal with a legacy codebase still written in JavaScript, many of which are new since we disabled checking these files.This PR fixes all the type errors in a couple different ways:
.d.tsfile was simple enough, the source file was just converted to TypeScriptPropstypes withRecord<any, any>index.d.tsfile, so I converted thoseindex.jsfiles toindex.tsand typed the imports, making it easier to remove.d.tsfiles in the future as components are converted to TS and now new .js exports will trigger type failures to encourage gradual migration to TSThe functionality of the monitoring plugin shouldn't be effected by these changes, though please double check that they all make sense to you.
[skip ci]