Skip to content

[ts] Check .d.ts files for all projects in typeCheck #114295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 6 commits into from
Oct 13, 2021
Merged

[ts] Check .d.ts files for all projects in typeCheck #114295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
319bfea
enable --skip-lib-check for all projects in typeCheck and fix existin…
spalger Oct 7, 2021
98ea1f9
fix graph types
spalger Oct 7, 2021
3a4a992
transpile TS to ES2019, but not all the way back to es5
spalger Oct 7, 2021
904d763
Merge branch 'master' of github.com:elastic/kibana into implement/che…
spalger Oct 11, 2021
7f127ae
Merge branch 'master' into implement/check-lib-files-on-ci
kibanamachine Oct 12, 2021
81aebfb
Merge branch 'master' into implement/check-lib-files-on-ci
kibanamachine Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/dev/typescript/run_type_check_cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,23 +53,8 @@ export async function runTypeCheckCli() {
}
}

const nonCompositeProjects = projects.filter((p) => !p.isCompositeProject());
if (!nonCompositeProjects.length) {
if (projectFilter) {
log.success(
`${flags.project} is a composite project so its types are validated by scripts/build_ts_refs`
);
} else {
log.success(
`All projects are composite so their types are validated by scripts/build_ts_refs`
);
}

return;
}

const concurrency = Math.min(4, Math.round((Os.cpus() || []).length / 2) || 1) || 1;
log.info('running type check in', nonCompositeProjects.length, 'non-composite projects');
log.info('running type check in', projects.length, 'projects');

const tscArgs = [
...['--emitDeclarationOnly', 'false'],
Expand All @@ -81,7 +66,7 @@ export async function runTypeCheckCli() {
];

const failureCount = await lastValueFrom(
Rx.from(nonCompositeProjects).pipe(
Rx.from(projects).pipe(
mergeMap(async (p) => {
const relativePath = Path.relative(process.cwd(), p.tsConfigPath);

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/graph/public/services/workspace/graph_client_workspace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
* 2.0.
*/

import { Workspace, WorkspaceOptions } from '../types';
import { Workspace, WorkspaceOptions } from '../../types';

declare function createWorkspace(options: WorkspaceOptions): Workspace;
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/server/lib/puid.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

declare module 'puid' {
declare class Puid {
class Puid {
generate(): string;
}

Expand Down
7 changes: 3 additions & 4 deletions x-pack/plugins/security_solution/cypress/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@
"target/**/*"
],
"compilerOptions": {
"target": "es5",
"lib": ["es5", "dom"],
"target": "ES2019",
"outDir": "target/types",
"types": [
"cypress",
"cypress-pipe",
"node"
"node",
"resize-observer-polyfill",
],
"resolveJsonModule": true,
},
"references": [
{ "path": "../tsconfig.json" }
Expand Down