Bumping EUI to 38.0.1 #112462
Merged
Bumping EUI to 38.0.1 #112462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Copenut
added
auto-backport
8 tasks
1Copenut
commented
Sep 23, 2021
| await retry.try(async () => { | ||
| const panelTitles = await PageObjects.dashboard.getPanelTitles(); | ||
| expect(panelTitles).to.eql(PageObjects.dashboard.getTestVisualizationNames()); | ||
| const visiblePanelTitles = panelTitles.map((title) => title.split('\n')[1]); |
Contributor
Author
There was a problem hiding this comment.
@constancecchen I wrote a helper method called getVisiblePanelTitles() after I wrote this string split a second or third time. I think we can clean these up to use that method (assuming tests still pass) but I wanted to get to green before refactoring.
Contributor
There was a problem hiding this comment.
Just a hunch, but I think many these issues/functional failures will go away if we backport a fix to our EuiScreenReaderOnly change: elastic/eui#5215
This was referenced Sep 24, 2021
* Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions
* package.json * package-lock.json * license-checker
Contributor
|
Pinging @elastic/eui-design (EUI) |
Contributor
|
@elasticmachine merge upstream |
spalger
approved these changes
Sep 27, 2021
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @1Copenut |
pgayvallet
approved these changes
Sep 28, 2021
crob611
approved these changes
Sep 29, 2021
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
Presentation changes LGTM
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
* Bumping EUI to 38.0.0 * Updating storyshots.test.tsx snapshot * Removing unneeded ID mock and updating snapshot. * Fixing panel titles by splitting visible labels. * Updating one functional test for Discover > Data Grid * Fixing one test on a Lens > Smokescreen accessible label * Updating four tests to use visible labels only. * Adding helper function to retrieve visual text only and fixing three tests. * Dashboard > Panel Cloning all tests pass. * Fixing accessible label test * Fixing data_shared_attributes, two tests * Updating tests for Discover > Data Grid * Reverting tests ahead of EUI 38.0.1 backport * Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions * Bumping configuration files to EUI 38.0.1 * package.json * package-lock.json * license-checker Co-authored-by: Kibana Machine <[email protected]>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
* Bumping EUI to 38.0.0 * Updating storyshots.test.tsx snapshot * Removing unneeded ID mock and updating snapshot. * Fixing panel titles by splitting visible labels. * Updating one functional test for Discover > Data Grid * Fixing one test on a Lens > Smokescreen accessible label * Updating four tests to use visible labels only. * Adding helper function to retrieve visual text only and fixing three tests. * Dashboard > Panel Cloning all tests pass. * Fixing accessible label test * Fixing data_shared_attributes, two tests * Updating tests for Discover > Data Grid * Reverting tests ahead of EUI 38.0.1 backport * Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions * Bumping configuration files to EUI 38.0.1 * package.json * package-lock.json * license-checker Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Trevor Pierce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[email protected]⏩[email protected]38.0.1Reverts
EuiScreenReaderOnlyleft positioning change due to Selenium issues (#5215)38.0.0EuiCodeBlock(#4993)emoticonsupport and removed rendered<div>fromEuiMarkdownFormat(#5176)EuiCheckboxandEuiRadioinputs to always float inline on top of the faux inputs (#5152)Bug fixes
EuiDataGridstripes not alternating as expected on sort/pagination (#5070)Breaking changes
clipproperty toEuiScreenReaderOnly, to fix positioning issues within scrolling containers (#5152)37.7.0placeholderprop toEuiMarkdownEditor(#5151).eui-textNumberutility class to applytnumfont-feature setting (#5078)EuiPageHeader's tab implementation to use sizexlwhen only content (#5135)pageTitlePropsprop toEuiPageHeaderto pass through props to theEuiTitle(#5135)<h1>toEuiPageHeaderwhen tabs exist without apageTitle(#5135)bottomBorderprop andxlsizetoEuiTabs(#5135)prependandappendprops toEuiTab(#5135)EuiTabs(#5135)EuiTabsfont size ($euiTabFontSize, $euiTabFontSizeS, $euiTabFontSizeL) (#5135)EuiTabPropsfor eachEuiTabbedContentTab(#5135)EuiPopover'srepositionOnScrollfunction to prevent popover and input elements from separating on scroll when nested inEuiFlyout(#5155)repositionOnScrollprop toEuiSuperSelect(#5155)useGeneratedHtmlIdutility, which memoizes the randomly generated ID on mount and prevents regenerated IDs on component rerender (#5133)z-indexstyles that were causing parts ofEuiResizableContainerto overlapEuiHeader(#5164)Bug fixes
EuiDataGridwhen cells are removed from the DOM via virtualization (#5163)Theme: Amsterdam
displayprop ofEuiTabsin favor of unified styles andbottomBorder(#5135)37.6.2Reverts
EuiScreenReaderOnlyclip property (#5150)37.6.1Bug fixes
EuiScreenReaderOnlypositioning issues within scrolling containers (#5130)EuiDataGridcell actions not unmounting from the DOM after mouse interaction (#5120)EuiDataGridcell interactions' performance (#5136)