Adding helper function to retrieve visual text only and fixing three tests.

Author: 1Copenut

test/functional/apps/dashboard/dashboard_options.ts

@@ -18,6 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
   describe('dashboard data-shared attributes', () => {
     let originalTitles: string[] = [];
+    let originalAccessibleTitles: string[] = [];
 
     before(async () => {
       await esArchiver.load('test/functional/fixtures/es_archiver/dashboard/current/kibana');
@@ -28,23 +29,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.dashboard.preserveCrossAppState();
       await PageObjects.dashboard.loadSavedDashboard('few panels');
       await PageObjects.dashboard.switchToEditMode();
-      originalTitles = await PageObjects.dashboard.getPanelTitles();
+      originalTitles = await PageObjects.dashboard.getVisiblePanelTitles();
+      originalAccessibleTitles = await PageObjects.dashboard.getPanelTitles();
     });
 
     it('should be able to hide all panel titles', async () => {
       await PageObjects.dashboard.checkHideTitle();
       await retry.try(async () => {
-        const titles = await PageObjects.dashboard.getPanelTitles();
+        const titles = await PageObjects.dashboard.getVisiblePanelTitles();
         expect(titles[0]).to.eql('');
       });
     });
 
     it('should be able to unhide all panel titles', async () => {
       await PageObjects.dashboard.checkHideTitle();
       await retry.try(async () => {
-        const titles = await PageObjects.dashboard.getPanelTitles();
+        const titles = await PageObjects.dashboard.getVisiblePanelTitles();
         expect(titles[0]).to.eql(originalTitles[0]);
       });
     });
+
+    it('should always present accessible labels', async () => {
+      await PageObjects.dashboard.checkHideTitle();
+      await retry.try(async () => {
+        const titles = await PageObjects.dashboard.getPanelTitles();
+        expect(titles[0]).to.eql(originalAccessibleTitles[0]);
+      });
+    });
   });
 }

test/functional/apps/dashboard/panel_replacing.ts

@@ -85,7 +85,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await dashboardReplacePanel.replaceEmbeddable(replacedSearch, 'search');
       await PageObjects.header.waitUntilLoadingHasFinished();
       await PageObjects.dashboard.waitForRenderComplete();
-      const panelTitles = await PageObjects.dashboard.getPanelTitles();
+      const panelTitles = await PageObjects.dashboard.getVisiblePanelTitles();
       expect(panelTitles.length).to.be(2);
       expect(panelTitles[0]).to.be(replacedSearch);
     });

test/functional/apps/management/_index_pattern_create_delete.js

@@ -111,8 +111,7 @@ export default function ({ getService, getPageObjects }) {
 
           const comparedHeaders = headers.map(function compareHead(header, i) {
             return header.getVisibleText().then(function (text) {
-              const visibleText = text.split('\n')[1];
-              expect(visibleText).to.be(expectedHeaders[i]);
+              expect(text).to.be(expectedHeaders[i]);
             });
           });
 

test/functional/page_objects/dashboard_page.ts

@@ -516,6 +516,20 @@ export class DashboardPageObject extends FtrService {
     return await Promise.all(titleObjects.map(async (title) => await title.getVisibleText()));
   }
 
+  public async getVisiblePanelTitles() {
+    this.log.debug('visible in getPanelTitles');
+    const titleObjects = await this.testSubjects.findAll('dashboardPanelTitle');
+    return await Promise.all(
+      titleObjects.map(async (title) =>
+        (
+          await title.findByCssSelector(
+            '* :not(.euiScreenReaderOnly, .euiScreenReaderOnly--showOnFocus)'
+          )
+        ).getVisibleText()
+      )
+    );
+  }
+
   public async getPanelDimensions() {
     const panels = await this.find.allByCssSelector('.react-grid-item'); // These are gridster-defined elements and classes
     return await Promise.all(