[EuiMarkdownFormat] Removed emoticon support and extra rendered <div>
#5176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2021 16:31
This doesn’t affect regular `:__:` syntax, just those that try to turn certain character combos like `x)` into one, which can occur frequently in code related contexts.
cee-chen
reviewed
Sep 13, 2021
cchaos
changed the title
emoticon support removed extra rendered <div>emoticon support and extra rendered <div>
added 2 commits
September 13, 2021 17:06
This reverts commit f4f80d3.
cee-chen
reviewed
Sep 13, 2021
Co-authored-by: Constance <[email protected]>
cee-chen
approved these changes
Sep 13, 2021
Contributor
cee-chen
left a comment
cee-chen
left a comment
There was a problem hiding this comment.
Looks great to me from a code perspective! Not sure if you want to wait @chandlerprall or @miukimiu to approve though from a product design POV 🦅
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5176/ |
elizabetdev
approved these changes
Sep 14, 2021
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
Yes! The emoticon was really annoying as we can see in that CodeSandbox link (using the markdown format).
It seems that the extra div was not doing anything! So no problem with removing it. 😄
Tested in Chrome, Safari, and Firefox, and LGTM! 🎉
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5176/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
emoticonsupport specificallyThis doesn’t affect regular
:__:syntax, just those that try to turn certain character combos likex)into one, which can occur frequently in code related contexts.Before
After
Fixed extra bottom margins by removing extra rendered
<div>This was causing all of the last items like
<p>to keep their bottom margins which would throw off layouts in consuming applications. We were already only adding bottom margin to text elements if:not(:last-child)in.euiText. But since that wrapping div threw off the nested selector, it never applied.Before
After
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Checked Code Sandbox works for any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes