[TSVB] Rename Index pattern to Data view by DianaDerevyankina · Pull Request #110253 · elastic/kibana

DianaDerevyankina · 2021-08-26T14:42:53Z

Summary

Renamed index patterns to data views in TSVB UI.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

For maintainers

This was checked for breaking API changes and was labeled appropriately

# Conflicts: # src/plugins/vis_type_timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx # src/plugins/vis_type_timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx # src/plugins/vis_type_timeseries/public/application/components/series_config.js # src/plugins/vis_type_timeseries/public/application/components/use_index_patter_mode_callout.tsx # src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/config.js # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

VladLasitsa

LGTM

stratoula · 2021-09-30T06:58:40Z

src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js

-            label={i18n.translate('visTypeTimeseries.timeSeries.overrideIndexPatternLabel', {
-              defaultMessage: 'Override Index Pattern?',
+            label={i18n.translate('visTypeTimeseries.timeSeries.overrideDataViewLabel', {
+              defaultMessage: 'Override data view?',


@KOTungseth @gchaps here the data view should be capitalized as the Index Pattern was before? I just noticed that we are using Index patterns as:

Index pattern

Index Pattern

index pattern
Which is the correct one ? (in order to apply it correctly to the Data view)

index pattern and data view are correct. We only capitalize at the beginning of a sentence or in feature titles: https://elastic.github.io/eui/#/guidelines/writing#capitalization

elasticmachine · 2021-09-30T07:00:28Z

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

DianaDerevyankina · 2021-10-01T07:15:51Z

@elasticmachine merge upstream

...s/timeseries/public/application/components/lib/index_pattern_select/index_pattern_select.tsx

...es/timeseries/public/application/components/lib/index_pattern_select/switch_mode_popover.tsx

jrodewig · 2021-10-01T18:59:55Z

src/plugins/vis_types/timeseries/public/application/components/vis_types/timeseries/config.js

-            label={i18n.translate('visTypeTimeseries.timeSeries.overrideIndexPatternLabel', {
-              defaultMessage: 'Override Index Pattern?',
+            label={i18n.translate('visTypeTimeseries.timeSeries.overrideDataViewLabel', {
+              defaultMessage: 'Override data view?',


index pattern and data view are correct. We only capitalize at the beginning of a sentence or in feature titles: https://elastic.github.io/eui/#/guidelines/writing#capitalization

jrodewig

@gchaps asked me to take a look at the copy here.

While I'm a poor substitute for Gail or Kaarina, I did leave a few comments based on a writer's perspective. I'll take another look once those are addressed. Feel free to ping me if you have questions.

And sorry for the out-of-order comments. My review kinda slipped out before I intended it to.

...plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx

DianaDerevyankina · 2021-10-04T07:37:39Z

@elasticmachine merge upstream

stratoula

This seems good Diana! LGTM. I tested it locally and everything looks fine :)

jrodewig

LGTM. Thanks, @dziyanadzeraviankina!

alexwizp

LGTM! Thank you

kibanamachine · 2021-10-04T15:54:45Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeTimeseries`	486.0KB	486.1KB	+71.0B

History

💛 Build #157511 was flaky cc24dcb
💚 Build #157503 succeeded 60bacd2
💚 Build #157484 succeeded 9a3cea4
💔 Build #157494 failed f6cbe05
💚 Build #157392 succeeded 7e6d145

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

The TSVB data view popover includes additional copy if the **Allow string indices in TSVB** Kibana setting is disabled (the default). This updates the copy to better align with changes in #110253.

This reverts commit 51df1e5.

* [TSVB] Rename Index pattern to Data view * Update some labels * Make asterisk bold to indicate it's text input * Remove redundant translation * Remove "now" from TSVB callout notification title * Update variable name to match the text Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [TSVB] Rename Index pattern to Data view * Update some labels * Make asterisk bold to indicate it's text input * Remove redundant translation * Remove "now" from TSVB callout notification title * Update variable name to match the text Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[TSVB] Rename Index pattern to Data view

547913a

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 26, 2021

DianaDerevyankina self-assigned this Aug 26, 2021

DianaDerevyankina requested review from VladLasitsa and alexwizp August 27, 2021 07:46

DianaDerevyankina requested review from dej611, mbondyra and stratoula September 7, 2021 08:52

DianaDerevyankina added backport:skip This PR does not require backporting and removed v7.16.0 labels Sep 29, 2021

VladLasitsa approved these changes Sep 29, 2021

View reviewed changes

stratoula reviewed Sep 30, 2021

View reviewed changes

stratoula marked this pull request as ready for review September 30, 2021 07:00

stratoula requested a review from a team as a code owner September 30, 2021 07:00

Merge branch 'master' into TSVB-index-pattern-to-data-view

41f7f8f

stratoula requested a review from gchaps October 1, 2021 09:36

jrodewig reviewed Oct 1, 2021

View reviewed changes

...plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx Outdated Show resolved Hide resolved

...plugins/vis_types/timeseries/public/application/components/use_index_patter_mode_callout.tsx Outdated Show resolved Hide resolved

kibanamachine and others added 4 commits October 4, 2021 03:37

Merge branch 'master' into TSVB-index-pattern-to-data-view

7e6d145

Update some labels

9a3cea4

Make asterisk bold to indicate it's text input

f6cbe05

Remove redundant translation

60bacd2

Remove "now" from TSVB callout notification title

cc24dcb

stratoula approved these changes Oct 4, 2021

View reviewed changes

jrodewig approved these changes Oct 4, 2021

View reviewed changes

DianaDerevyankina added 2 commits October 4, 2021 16:43

Merge branch 'master' into TSVB-index-pattern-to-data-view

c145ef9

Update variable name to match the text

a908e3a

alexwizp approved these changes Oct 4, 2021

View reviewed changes

DianaDerevyankina merged commit 51df1e5 into elastic:master Oct 4, 2021

jrodewig mentioned this pull request Oct 5, 2021

[TSVB] Update copy for string indices setting popover #113990

Merged

1 task

DianaDerevyankina added a commit that referenced this pull request Oct 7, 2021

Revert "[TSVB] Rename Index pattern to Data view (#110253)"

5c43acd

This reverts commit 51df1e5.

DianaDerevyankina mentioned this pull request Oct 7, 2021

Revert "[TSVB] Rename Index pattern to Data view" #114278

Merged

DianaDerevyankina added a commit that referenced this pull request Oct 7, 2021

Revert "[TSVB] Rename Index pattern to Data view (#110253)" (#114278)

2e6ce13

This reverts commit 51df1e5.

Conversation

DianaDerevyankina commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

VladLasitsa left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula Sep 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrodewig Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 30, 2021

Uh oh!

DianaDerevyankina commented Oct 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrodewig Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrodewig left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DianaDerevyankina commented Oct 4, 2021

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

jrodewig left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 4, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DianaDerevyankina commented Aug 26, 2021 •

edited

Loading

stratoula Sep 30, 2021 •

edited

Loading

jrodewig Oct 1, 2021 •

edited

Loading

jrodewig Oct 1, 2021 •

edited

Loading

jrodewig left a comment •

edited

Loading