Skip to content

[TSVB] Update copy for string indices setting popover#113990

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__update-tsvb-setting-copy
Oct 6, 2021
Merged

[TSVB] Update copy for string indices setting popover#113990
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__update-tsvb-setting-copy

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Oct 5, 2021

Summary

The TSVB data view popover includes additional copy if the Allow string indices in TSVB Kibana setting is disabled (the default). This updates the copy to better align with changes in #110253.

Screen Shot 2021-10-05 at 2 48 35 PM

Testing instructions

  1. In terminal, run yarn es snapshot --license=trial.
  2. In a new terminal session, run yarn start.
  3. Open Kibana, click Try sample data, and add the sample web logs data.
  4. In the main menu, click Dashboard.
  5. From the All types drop-down, select TSVB.
  6. Click Panel Options. Click the gear icon in the Data view drop-down.

Checklist

@jrodewig jrodewig added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Oct 5, 2021
@jrodewig jrodewig requested a review from a team as a code owner October 5, 2021 18:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 486.1KB 486.1KB +10.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text lgtm

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM!

@jrodewig jrodewig merged commit 634cd80 into elastic:master Oct 6, 2021
@jrodewig jrodewig deleted the docs__update-tsvb-setting-copy branch October 6, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants