Skip to content
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,28 @@ export interface IndexPatternSelectProps {
| null;
}

const defaultIndexPatternHelpText = i18n.translate(
'visTypeTimeseries.indexPatternSelect.defaultIndexPatternText',
{
defaultMessage: 'Default index pattern is used.',
}
const queryAllIndicesHelpText = (
<FormattedMessage
id="visTypeTimeseries.indexPatternSelect.queryAllIndicesText"
defaultMessage="To query all indices, use {asterisk}."
values={{
asterisk: <strong>*</strong>,
}}
/>
);

const queryAllIndexesHelpText = i18n.translate(
'visTypeTimeseries.indexPatternSelect.queryAllIndexesText',
{
defaultMessage: 'To query all indexes use *',
}
const getIndexPatternHelpText = (useKibanaIndices: boolean) => (
<FormattedMessage
id="visTypeTimeseries.indexPatternSelect.defaultDataViewText"
defaultMessage="Using the default data view. {queryAllIndicesHelpText}"
values={{
queryAllIndicesHelpText: useKibanaIndices ? '' : queryAllIndicesHelpText,
}}
/>
);

const indexPatternLabel = i18n.translate('visTypeTimeseries.indexPatternSelect.label', {
defaultMessage: 'Index pattern',
defaultMessage: 'Data view',
});

export const IndexPatternSelect = ({
Expand Down Expand Up @@ -103,17 +109,14 @@ export const IndexPatternSelect = ({
<EuiFormRow
id={htmlId('indexPattern')}
label={indexPatternLabel}
helpText={
fetchedIndex.defaultIndex &&
defaultIndexPatternHelpText + (!useKibanaIndices ? queryAllIndexesHelpText : '')
}
helpText={fetchedIndex.defaultIndex && getIndexPatternHelpText(useKibanaIndices)}
labelAppend={
fetchedIndex.indexPatternString && !fetchedIndex.indexPattern ? (
<EuiLink onClick={navigateToCreateIndexPatternPage}>
<EuiText size="xs">
<FormattedMessage
id="visTypeTimeseries.indexPatternSelect.createIndexPatternText"
defaultMessage="Create index pattern"
id="visTypeTimeseries.indexPatternSelect.createDataViewText"
defaultMessage="Create data view"
/>
</EuiText>
</EuiLink>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
aria-label={i18n.translate(
'visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel',
{
defaultMessage: 'Configure index pattern selection mode',
defaultMessage: 'Configure data view selection mode',
}
)}
onClick={onButtonClick}
Expand All @@ -97,14 +97,13 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
>
<EuiPopoverTitle>
{i18n.translate('visTypeTimeseries.indexPatternSelect.switchModePopover.title', {
defaultMessage: 'Index pattern selection mode',
defaultMessage: 'Data view mode',
})}
</EuiPopoverTitle>
<EuiText>
<FormattedMessage
id="visTypeTimeseries.indexPatternSelect.switchModePopover.text"
defaultMessage="An index pattern identifies one or more Elasticsearch indices that you want to explore.
Kibana index patterns are used by default. {allowStringIndicesLabel}"
defaultMessage="A data view groups and retrieves data from Elasticsearch. Disable this mode to directly query Elasticsearch indices instead. {allowStringIndicesLabel}"
values={{
allowStringIndicesLabel,
}}
Expand All @@ -116,7 +115,7 @@ export const SwitchModePopover = ({ onModeChange, useKibanaIndices }: PopoverPro
label={i18n.translate(
'visTypeTimeseries.indexPatternSelect.switchModePopover.useKibanaIndices',
{
defaultMessage: 'Use only index patterns',
defaultMessage: 'Use Kibana data views',
}
)}
onChange={switchMode}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ export const SeriesConfig = (props) => {
<EuiFlexGroup gutterSize="s" responsive={false} wrap={true}>
<EuiFlexItem grow={false}>
<EuiFormRow
label={i18n.translate('visTypeTimeseries.seriesConfig.overrideIndexPatternLabel', {
defaultMessage: 'Override Index Pattern?',
label={i18n.translate('visTypeTimeseries.seriesConfig.overrideDataViewLabel', {
defaultMessage: 'Override data view?',
})}
>
<YesNo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,22 @@ export const UseIndexPatternModeCallout = () => {
<EuiCallOut
title={
<FormattedMessage
id="visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle"
defaultMessage="TSVB now supports index patterns"
id="visTypeTimeseries.visEditorVisualization.dataViewMode.notificationTitle"
defaultMessage="TSVB supports data views"
/>
}
iconType="cheer"
size="s"
>
<p>
<FormattedMessage
id="visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationMessage"
defaultMessage="Great news! You can now visualize the data from Kibana index patterns (recommended) or Elasticsearch indices. {indexPatternModeLink}."
id="visTypeTimeseries.visEditorVisualization.dataViewMode.notificationMessage"
defaultMessage="Great news! You can visualize the data from Kibana data views (recommended) or Elasticsearch indices. {indexPatternModeLink}."
values={{
indexPatternModeLink: (
<EuiLink href={indexPatternModeLink} target="_blank" external>
<FormattedMessage
id="visTypeTimeseries.visEditorVisualization.indexPatternMode.link"
id="visTypeTimeseries.visEditorVisualization.dataViewMode.link"
defaultMessage="Check it out."
/>
</EuiLink>
Expand All @@ -59,7 +59,7 @@ export const UseIndexPatternModeCallout = () => {
<EuiFlexGroup gutterSize="none">
<EuiButton size="s" onClick={dismissNotice}>
<FormattedMessage
id="visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText"
id="visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText"
defaultMessage="Dismiss"
/>
</EuiButton>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,8 @@ export const TimeseriesConfig = injectI18n(function (props) {
<EuiFlexGroup gutterSize="s" responsive={false} wrap={true}>
<EuiFlexItem grow={false}>
<EuiFormRow
label={i18n.translate('visTypeTimeseries.timeSeries.overrideIndexPatternLabel', {
defaultMessage: 'Override Index Pattern?',
label={i18n.translate('visTypeTimeseries.timeSeries.overrideDataViewLabel', {
defaultMessage: 'Override data view?',
Copy link
Copy Markdown
Contributor

@stratoula stratoula Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KOTungseth @gchaps here the data view should be capitalized as the Index Pattern was before? I just noticed that we are using Index patterns as:

  • Index pattern
  • Index Pattern
  • index pattern
    Which is the correct one ? (in order to apply it correctly to the Data view)

Copy link
Copy Markdown
Contributor

@jrodewig jrodewig Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index pattern and data view are correct. We only capitalize at the beginning of a sentence or in feature titles: https://elastic.github.io/eui/#/guidelines/writing#capitalization

})}
>
<YesNo
Expand Down
13 changes: 2 additions & 11 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -5198,12 +5198,6 @@
"visTypeTimeseries.indexPattern.timeRange.lastValue": "最終値",
"visTypeTimeseries.indexPattern.timeRange.selectTimeRange": "選択してください",
"visTypeTimeseries.indexPattern.сoarse": "粗い",
"visTypeTimeseries.indexPatternSelect.createIndexPatternText": "インデックスパターンを作成",
"visTypeTimeseries.indexPatternSelect.defaultIndexPatternText": "デフォルトのインデックスパターンが使用されています。",
"visTypeTimeseries.indexPatternSelect.label": "インデックスパターン",
"visTypeTimeseries.indexPatternSelect.queryAllIndexesText": "すべてのインデックスにクエリを実行するには * を使用します",
"visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel": "インデックスパターン選択モードを構成",
"visTypeTimeseries.indexPatternSelect.switchModePopover.title": "インデックスパターン選択モード",
"visTypeTimeseries.kbnVisTypes.metricsDescription": "時系列データの高度な分析を実行します。",
"visTypeTimeseries.kbnVisTypes.metricsTitle": "TSVB",
"visTypeTimeseries.lastValueModeIndicator.lastBucketDate": "バケット:{lastBucketDate}",
Expand Down Expand Up @@ -5332,7 +5326,6 @@
"visTypeTimeseries.seriesConfig.ignoreGlobalFilterLabel": "グローバルフィルターを無視しますか?",
"visTypeTimeseries.seriesConfig.missingSeriesComponentDescription": "パネルタイプ {panelType} の数列コンポーネントが欠けています",
"visTypeTimeseries.seriesConfig.offsetSeriesTimeLabel": "数列の時間を(1m, 1h, 1w, 1d)でオフセット",
"visTypeTimeseries.seriesConfig.overrideIndexPatternLabel": "インデックスパターンを上書きしますか?",
"visTypeTimeseries.seriesConfig.templateHelpText": "eg. {templateExample}",
"visTypeTimeseries.seriesConfig.templateLabel": "テンプレート",
"visTypeTimeseries.sort.dragToSortAriaLabel": "ドラッグして並べ替えます",
Expand Down Expand Up @@ -5463,7 +5456,6 @@
"visTypeTimeseries.timeseries.optionsTab.styleLabel": "スタイル",
"visTypeTimeseries.timeseries.optionsTab.tooltipMode": "ツールチップ",
"visTypeTimeseries.timeseries.optionsTab.truncateLegendLabel": "凡例を切り捨てますか?",
"visTypeTimeseries.timeSeries.overrideIndexPatternLabel": "インデックスパターンを上書きしますか?",
"visTypeTimeseries.timeSeries.percentLabel": "パーセント",
"visTypeTimeseries.timeseries.positionOptions.leftLabel": "左",
"visTypeTimeseries.timeseries.positionOptions.rightLabel": "右",
Expand Down Expand Up @@ -5528,9 +5520,8 @@
"visTypeTimeseries.visEditorVisualization.changesHaveNotBeenAppliedMessage": "ビジュアライゼーションへの変更が適用されました。",
"visTypeTimeseries.visEditorVisualization.changesSuccessfullyAppliedMessage": "最新の変更が適用されました。",
"visTypeTimeseries.visEditorVisualization.changesWillBeAutomaticallyAppliedMessage": "変更が自動的に適用されます。",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText": "閉じる",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.link": "確認してください。",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle": "TSVBはインデックスパターンをサポートします",
"visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText": "閉じる",
"visTypeTimeseries.visEditorVisualization.dataViewMode.link": "確認してください。",
"visTypeTimeseries.visPicker.gaugeLabel": "ゲージ",
"visTypeTimeseries.visPicker.metricLabel": "メトリック",
"visTypeTimeseries.visPicker.tableLabel": "表",
Expand Down
13 changes: 2 additions & 11 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -5241,12 +5241,6 @@
"visTypeTimeseries.indexPattern.timeRange.lastValue": "最后值",
"visTypeTimeseries.indexPattern.timeRange.selectTimeRange": "选择",
"visTypeTimeseries.indexPattern.сoarse": "粗糙",
"visTypeTimeseries.indexPatternSelect.createIndexPatternText": "创建索引模式",
"visTypeTimeseries.indexPatternSelect.defaultIndexPatternText": "将使用默认索引模式。",
"visTypeTimeseries.indexPatternSelect.label": "索引模式",
"visTypeTimeseries.indexPatternSelect.queryAllIndexesText": "要查询所有索引,请使用 *",
"visTypeTimeseries.indexPatternSelect.switchModePopover.areaLabel": "配置索引模式选择模式",
"visTypeTimeseries.indexPatternSelect.switchModePopover.title": "索引模式选择模式",
"visTypeTimeseries.kbnVisTypes.metricsDescription": "对时间序列数据执行高级分析。",
"visTypeTimeseries.kbnVisTypes.metricsTitle": "TSVB",
"visTypeTimeseries.lastValueModeIndicator.lastBucketDate": "存储桶:{lastBucketDate}",
Expand Down Expand Up @@ -5376,7 +5370,6 @@
"visTypeTimeseries.seriesConfig.ignoreGlobalFilterLabel": "忽略全局筛选?",
"visTypeTimeseries.seriesConfig.missingSeriesComponentDescription": "以下面板类型缺失序列组件:{panelType}",
"visTypeTimeseries.seriesConfig.offsetSeriesTimeLabel": "将序列时间偏移(1m、1h、1w、1d)",
"visTypeTimeseries.seriesConfig.overrideIndexPatternLabel": "覆盖索引模式?",
"visTypeTimeseries.seriesConfig.templateHelpText": "例如 {templateExample}",
"visTypeTimeseries.seriesConfig.templateLabel": "模板",
"visTypeTimeseries.sort.dragToSortAriaLabel": "拖动以排序",
Expand Down Expand Up @@ -5507,7 +5500,6 @@
"visTypeTimeseries.timeseries.optionsTab.styleLabel": "样式",
"visTypeTimeseries.timeseries.optionsTab.tooltipMode": "工具提示",
"visTypeTimeseries.timeseries.optionsTab.truncateLegendLabel": "截断图例?",
"visTypeTimeseries.timeSeries.overrideIndexPatternLabel": "覆盖索引模式?",
"visTypeTimeseries.timeSeries.percentLabel": "百分比",
"visTypeTimeseries.timeseries.positionOptions.leftLabel": "左",
"visTypeTimeseries.timeseries.positionOptions.rightLabel": "右",
Expand Down Expand Up @@ -5572,9 +5564,8 @@
"visTypeTimeseries.visEditorVisualization.changesHaveNotBeenAppliedMessage": "尚未应用对此可视化的更改。",
"visTypeTimeseries.visEditorVisualization.changesSuccessfullyAppliedMessage": "已应用最新更改。",
"visTypeTimeseries.visEditorVisualization.changesWillBeAutomaticallyAppliedMessage": "将自动应用更改。",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.dismissNoticeButtonText": "关闭",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.link": "请查看。",
"visTypeTimeseries.visEditorVisualization.indexPatternMode.notificationTitle": "TSVB 现在支持索引模式",
"visTypeTimeseries.visEditorVisualization.dataViewMode.dismissNoticeButtonText": "关闭",
"visTypeTimeseries.visEditorVisualization.dataViewMode.link": "请查看。",
"visTypeTimeseries.visPicker.gaugeLabel": "仪表盘",
"visTypeTimeseries.visPicker.metricLabel": "指标",
"visTypeTimeseries.visPicker.tableLabel": "表",
Expand Down