Skip to content

[DX] Upgrade prettier to v2.4.0#112359

Merged
tylersmalley merged 4 commits intoelastic:masterfrom
tylersmalley:bump-prettier
Sep 20, 2021
Merged

[DX] Upgrade prettier to v2.4.0#112359
tylersmalley merged 4 commits intoelastic:masterfrom
tylersmalley:bump-prettier

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Sep 15, 2021 •
edited
Loading

Release notes:

Most updates are caused by: Prevent wrapping object properties with short keys

Reviews:

  • All changes were automatically applied by prettier except those in 42b4c57a898cff802d78192b1368ae9762a7000a

Actions:

git cherry-pick 15222fd2acc9fff8f42bc505eaeb105c553b14cb
yarn kbn bootstrap
node scripts/eslint.js --fix
git add . && git commit -sm 'eslint auto-fix'
git cherry-pick 42b4c57a898cff802d78192b1368ae9762a7000a
node scripts/check_published_api_changes.js --accept
git add . && git commit -sm 'api docs'

@tylersmalley tylersmalley force-pushed the bump-prettier branch 2 times, most recently from 1ae4a84 to ccd911a Compare September 16, 2021 04:11
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0 labels Sep 16, 2021
@tylersmalley tylersmalley changed the title Bump prettier [DX] Upgrade prettier to v2.4.0 Sep 16, 2021
@tylersmalley tylersmalley marked this pull request as ready for review September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team as code owners September 16, 2021 16:02
@tylersmalley tylersmalley requested review from a team September 16, 2021 16:02
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 16, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley requested review from a team, dasansol92 and pzl September 16, 2021 16:02
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Sep 16, 2021
YulNaumenko
YulNaumenko approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM!

cjcenizal
cjcenizal approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checked some of the Stack Management plugins. Changes LGTM.

@pzl pzl removed their request for review September 16, 2021 16:33
justinkambic
justinkambic approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM.

scottybollinger
scottybollinger approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enterprise Search (shared) and Workplace Search changes LGTM. Thanks for doing this!

@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Sep 16, 2021 •
edited
Loading

Since this change affects so much of the repository, I will be merging this over the three-day weekend when there are fewer commits. This will give me time to run CI and merge without any merge conflicts in the PR itself. I will follow up on this thread once that happens.

If you have ESLint failures after the merge, it can be resolved by running one of the following commands based on the marge you're targeting:

  • master: node scripts/precommit_hook.js --ref master
  • 7.x: node scripts/precommit_hook.js --ref 7.x

Please let me know if there are any concerns merging this without all code owner signoff.

This was referenced Sep 19, 2021
Merged
Closed
@tylersmalley
Bump prettier
01714cc 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
eslint auto-fix
77f1eeb 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Manual fixes
59a8a40 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
api docs
df0e928 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 20, 2021

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

  • 💚 Build #154113 succeeded 7089be9c1e6791f343bfdfd84d2ce14c016be65c
  • 💔 Build #154108 failed 9553c7cfe9fcf8bbe2ecaa63c09111b692efa14f
  • 💚 Build #153918 succeeded 9e724a550e2c5236dbae2262216f4b7e128f8b7a
  • 💚 Build #153739 succeeded ccd911aba5ac00c63a719f95d744cd33531a1aba
  • 💛 Build #153711 was flaky 9d760a9431200be0bfb41ab9b1e227923a52731f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 4681a80 into elastic:master Sep 20, 2021
tylersmalley added a commit that referenced this pull request Sep 20, 2021
@tylersmalley
[7.x][DX] Upgrade prettier to v2.4.0 (#112359) (#112524)
c16480e 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@TinaHeiligers TinaHeiligers mentioned this pull request Sep 20, 2021
Merged
7 tasks
@tylersmalley tylersmalley mentioned this pull request Oct 7, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smith smith smith approved these changes

@jbudz jbudz jbudz approved these changes

@justinkambic justinkambic justinkambic approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92

+3 more reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@scottybollinger scottybollinger scottybollinger approved these changes

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.