Skip to content

Revert "[Index Patterns] Move rollup config to index pattern management"#102276

Merged
mattkime merged 1 commit intomasterfrom
revert-102145-rollup_creation_code_to_index_pattern_mgmt
Jun 16, 2021
Merged

Revert "[Index Patterns] Move rollup config to index pattern management"#102276
mattkime merged 1 commit intomasterfrom
revert-102145-rollup_creation_code_to_index_pattern_mgmt

Conversation

@mattkime
Copy link
Contributor

Reverts #102145

fails on OSS builds which are only in the 7.x build process

@mattkime mattkime requested a review from a team as a code owner June 15, 2021 22:34
@mattkime mattkime added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 15, 2021
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexPatternManagement 167 162 -5
rollup 165 169 +4
total -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
indexPatternManagement 0 45 +45

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
rollup 230.2KB 230.2KB -9.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
indexPatternManagement 0 3 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexPatternManagement 19.5KB 12.9KB -6.6KB
rollup 33.8KB 40.8KB +7.0KB
total +423.0B
Unknown metric groups

API count

id before after diff
indexPatternManagement 0 45 +45

References to deprecated APIs

id before after diff
indexPatternManagement 0 68 +68

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 4cf6bca into master Jun 16, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102276 or prevent reminders by adding the backport:skip label.

@mattkime mattkime added the backport:skip This PR does not require backporting label Jun 18, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 18, 2021
@spalger spalger deleted the revert-102145-rollup_creation_code_to_index_pattern_mgmt branch May 8, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants