[XY axis] Fixes filters not work for charts with percentage mode.#100456
Merged
Kuznietsov merged 2 commits intoelastic:masterfrom May 26, 2021
Merged
[XY axis] Fixes filters not work for charts with percentage mode.#100456Kuznietsov merged 2 commits intoelastic:masterfrom
Kuznietsov merged 2 commits intoelastic:masterfrom
Conversation
Before this part of code was comparing clean data, which came from dataset, with X/Y values. They were true according to normal mode, but in percentage mode, for example, it was comparing absolute value with percentage value. To avoid it, need to compare datum (feature elastic#822 from elastic/elastic-charts) of geometry with clean value from row info.
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
alexwizp
changed the title
alexwizp
added
Team:Visualizations
Contributor
|
@nickofthyme could you please have a look? I've tested it locally and that changes fix reported problem. |
alexwizp
approved these changes
May 25, 2021
DianaDerevyankina
approved these changes
May 25, 2021
nickofthyme
approved these changes
May 25, 2021
Contributor
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM. Good catch, I didn't even think about the percentage value being the returned value.
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
@elasticmachine merge upstream |
stratoula
approved these changes
May 26, 2021
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
This works great, thank you @kuznetsov-y, changes LGTM
Contributor
|
Jenkins, test this |
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
Unknown metric groupsReferences to deprecated APIs
To update your PR or re-run it, just comment with: cc @kuznetsov-y |
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 26, 2021
…#100456) Before this part of code was comparing clean data, which came from dataset, with X/Y values. They were true according to normal mode, but in percentage mode, for example, it was comparing absolute value with percentage value. To avoid it, need to compare datum (feature elastic#822 from elastic/elastic-charts) of geometry with clean value from row info. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 26, 2021
…deprecation-ilm-policy * 'master' of github.com:elastic/kibana: (101 commits) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) Fixed comparing real value with formatted according to mode. (elastic#100456) [ftr] migrate "dataGrid" service to FtrService class (elastic#100593) [ftr] migrate "fieldEditor" to FtrService class (elastic#100597) [ftr] migrate "filterBar" service to FtrService class (elastic#100601) [triggersActionsUi] Reduce page load bundle to under 100kB (elastic#97770) [build] Clean jest configs (elastic#100594) refact(NA): remove extra pkg_npm target and add specific target folders for @kbn/analytics on Bazel (elastic#100569) Update dependency @elastic/charts to v29.2.0 (elastic#100587) [Maps] convert LayerPanel to typescript (elastic#100481) [Upgrade Assistant] Address copy feedback (elastic#99632) Open/Closed filter for observability alerts page (elastic#99217) One liner to expose the EQL query for debugging for users (elastic#100565) [KibanaPageLayout] Solution Nav specific styles & props (elastic#100089) [ftr] implement FtrService classes and migrate common services (elastic#99546) [XY] [Lens] Adds opacity slider (elastic#100453) [Reporting] ILM policy for managing reporting indices (elastic#100130) [Reporting] ILM policy for managing reporting indices (elastic#100130) [DOCS] Remove redundant maps attribute (elastic#100426) ... # Conflicts: # x-pack/plugins/reporting/server/lib/store/report_ilm_policy.ts # x-pack/plugins/reporting/server/lib/store/store.test.ts # x-pack/plugins/reporting/server/lib/store/store.ts
kibanamachine
added a commit
that referenced
this pull request
May 26, 2021
#100636) Before this part of code was comparing clean data, which came from dataset, with X/Y values. They were true according to normal mode, but in percentage mode, for example, it was comparing absolute value with percentage value. To avoid it, need to compare datum (feature #822 from elastic/elastic-charts) of geometry with clean value from row info. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yaroslav Kuznietsov <kuznetsov.yaroslav.yk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99906
Before this part of the code was comparing clean data, which came from the dataset, with X/Y values. They were true according to normal mode, but in percentage mode, for example, it was comparing the absolute value with a percentage value. To avoid it, need to compare datum (feature elastic/elastic-charts#822) of geometry with the clean value from row info.