feat: expose datum as part of GeometryValue#822
Merged
markov00 merged 9 commits intoelastic:masterfrom Sep 29, 2020
Merged
Conversation
markov00
added
enhancement
nickofthyme
approved these changes
Sep 15, 2020
Collaborator
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, tested locally on chrome.
…:markov00/elastic-charts into 2020_09_15-expose_datum_to_geometryvalue
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 74.09% 74.53% +0.43%
==========================================
Files 277 292 +15
Lines 9440 9724 +284
Branches 2037 2079 +42
==========================================
+ Hits 6995 7248 +253
- Misses 2436 2461 +25
- Partials 9 15 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
Author
|
Jenkins test this please |
markov00
pushed a commit
that referenced
this pull request
Sep 30, 2020
# [23.0.0](v22.0.0...v23.0.0) (2020-09-30) ### Bug Fixes * render continuous line/area between non-adjacent points ([#833](#833)) ([9f9892b](9f9892b)), closes [#825](#825) ### Features * debug state flag added to chart status ([#834](#834)) ([83919ff](83919ff)) * expose datum as part of GeometryValue ([#822](#822)) ([dcd7077](dcd7077)) ### BREAKING CHANGES * when rendering non-stacked line/area charts with a continuous x scale and no fit function, the line/area between non-consecutive data points will be rendered as a continuous line/area without adding an uncertain dashed line/ semi-transparent area that connects the two, non-adjacent, points.
Collaborator
Author
|
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [23.0.0](elastic/elastic-charts@v22.0.0...v23.0.0) (2020-09-30) ### Bug Fixes * render continuous line/area between non-adjacent points ([opensearch-project#833](elastic/elastic-charts#833)) ([5222c40](elastic/elastic-charts@5222c40)), closes [opensearch-project#825](elastic/elastic-charts#825) ### Features * debug state flag added to chart status ([opensearch-project#834](elastic/elastic-charts#834)) ([f3aba25](elastic/elastic-charts@f3aba25)) * expose datum as part of GeometryValue ([opensearch-project#822](elastic/elastic-charts#822)) ([e582bd6](elastic/elastic-charts@e582bd6)) ### BREAKING CHANGES * when rendering non-stacked line/area charts with a continuous x scale and no fit function, the line/area between non-consecutive data points will be rendered as a continuous line/area without adding an uncertain dashed line/ semi-transparent area that connects the two, non-adjacent, points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially address the concerns expressed here: #808
Is currently not allow using an object as a value for X or Y coordinates, so we kindly suggest to add an additional field into your data set that allows us to uniquely identify that object with a string or a number.
As a workaround for a click handler, a way to get back the original object from the stringified/number version is proposed in this PR, exposing the original
datumas part of theGeometryValueand as a consequence exposing the datum to every interaction handlers that use aGeometryValueChecklist