Fix newsfeed unread notifications always on when reloading Kibana#100357
Merged
pgayvallet merged 11 commits intoelastic:masterfrom Jun 2, 2021
Merged
Fix newsfeed unread notifications always on when reloading Kibana#100357pgayvallet merged 11 commits intoelastic:masterfrom
pgayvallet merged 11 commits intoelastic:masterfrom
Conversation
pgayvallet
added
v7.14.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
previously requested changes
May 24, 2021
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
LGTM! Code review only. I'm requesting changes because I believe that we can remove NewsfeedApiFetchResult, and maybe we should consider making the test with the date in the future a bit more dynamic.
src/plugins/newsfeed/public/components/newsfeed_header_nav_button.tsx
Outdated
Show resolved
Hide resolved
src/plugins/newsfeed/public/components/newsfeed_header_nav_button.tsx
Outdated
Show resolved
Hide resolved
joshdover
reviewed
May 27, 2021
| return true; | ||
| }; | ||
|
|
||
| export const convertItem = (rawItem: ApiItem, userLanguage: string): NewsfeedItem => { |
Contributor
There was a problem hiding this comment.
nit: seems like convert is a pretty vague term here, maybe this function and file should be localize_items instead?
Contributor
Author
There was a problem hiding this comment.
it makes sense to rename convertItem to localizeItem, however convertItems does more than that, as it also validates the content/dates of the news, so not sure the whole file should be renamed?
pgayvallet
requested review from
afharo and
joshdover
and removed request for
afharo
joshdover
approved these changes
Jun 1, 2021
Contributor
💚 Build SucceededMetrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jun 2, 2021
…astic#100357) * fix the implementation * add unit tests * add API unit tests * fix public interface * address review comments * name convertItem to localizeItem * use fetch instead of core.http and add tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 2, 2021
* master: (68 commits) Unskip advanced settings a11y test (elastic#100558) [App Search] Crawler Landing Page (elastic#100822) [DOCS] Clarify when to use kbn clean (elastic#101155) change label behavior (elastic#100991) skip flaky suite (elastic#101126) Fix cases plugin ownership (elastic#101073) [Home] Adding file upload to add data page (elastic#100863) [ML] Functional tests - reenable categorization tests (elastic#101137) [DOCS] Adds server.uuid to settings docs (elastic#101121) Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357) [Lens] Time shift metrics (elastic#98781) [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997) Add "Risk Matrix" section to the PR template (elastic#100649) [Maps] spatially filter by all geo fields (elastic#100735) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #99191
Fix the newsfeed unread notification being reset every time Kibana is reloaded
Checklist