Skip to content

[7.x] Fix newsfeed unread notifications always on when reloading Kibana (#100357)#101163

Merged
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-100357
Jun 2, 2021
Merged

[7.x] Fix newsfeed unread notifications always on when reloading Kibana (#100357)#101163
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-100357

Conversation

@pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

…astic#100357)

* fix the implementation

* add unit tests

* add API unit tests

* fix public interface

* address review comments

* name convertItem to localizeItem

* use fetch instead of core.http and add tests
@pgayvallet pgayvallet added the backport This PR is a backport of another PR label Jun 2, 2021
@pgayvallet pgayvallet enabled auto-merge (squash) June 2, 2021 14:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
newsfeed 16 14 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
newsfeed 19.0KB 18.1KB -959.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 0c57d8d into elastic:7.x Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants