Unskip advanced settings a11y test#100558
Merged
bhavyarm merged 4 commits intoelastic:masterfrom Jun 2, 2021
Merged
Conversation
bhavyarm
added
v8.0.0
Project:Accessibility
Feature:Kibana Management
Contributor
Author
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
myasonik
approved these changes
Jun 1, 2021
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
👍 It's a little over the top with the toast dismissal but it seems like the easiest way forward so it LGTM!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 2, 2021
* master: (68 commits) Unskip advanced settings a11y test (elastic#100558) [App Search] Crawler Landing Page (elastic#100822) [DOCS] Clarify when to use kbn clean (elastic#101155) change label behavior (elastic#100991) skip flaky suite (elastic#101126) Fix cases plugin ownership (elastic#101073) [Home] Adding file upload to add data page (elastic#100863) [ML] Functional tests - reenable categorization tests (elastic#101137) [DOCS] Adds server.uuid to settings docs (elastic#101121) Fix newsfeed unread notifications always on when reloading Kibana (elastic#100357) [Lens] Time shift metrics (elastic#98781) [Deprecations service] make `correctiveActions.manualSteps` required (elastic#100997) Add "Risk Matrix" section to the PR template (elastic#100649) [Maps] spatially filter by all geo fields (elastic#100735) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) ...
This was referenced Jun 2, 2021
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Jun 2, 2021
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Jun 2, 2021
bhavyarm
added a commit
that referenced
this pull request
Jun 2, 2021
bhavyarm
added a commit
that referenced
this pull request
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#99006 - Unskipping advances settings a11y test. Will be running in flaky test runner to figure out what is happening.