Skip to content

packages/microsoft_sqlserver: Fix HEALTHCHECK #10899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shmsr merged 3 commits into from
Aug 30, 2024
Merged

packages/microsoft_sqlserver: Fix HEALTHCHECK #10899

shmsr merged 3 commits into from
Aug 30, 2024

Conversation

@shmsr
Copy link
Member

@shmsr shmsr commented Aug 27, 2024 •
edited
Loading

Proposed commit message

Update the bin directory for sqlcmd because for 2019-latest the directory has changed and also how it works. Please see this comment and this comment for more details. As this is a change that affects only development, no CHANGELOG entry is needed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@shmsr shmsr requested a review from a team as a code owner August 27, 2024 19:18
@shmsr shmsr added the bug Something isn't working, use only for issues label Aug 27, 2024
@shmsr shmsr self-assigned this Aug 27, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] and removed bug Something isn't working, use only for issues labels Aug 27, 2024
@shmsr shmsr requested a review from a team as a code owner August 27, 2024 20:30
@shmsr shmsr force-pushed the microsoft_sqlserver_fix_ci_bin branch from f1d984d to 84b0780 Compare August 27, 2024 20:34
@shmsr shmsr removed request for a team, MichaelKatsoulis and gizas August 27, 2024 20:34
@elasticmachine
Copy link

elasticmachine commented Aug 27, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr
Copy link
Member Author

shmsr commented Aug 28, 2024

Also, see: #10889 (comment)

As tests were constantly failing had to debug it as well and track down the issue to:

ODBC driver version 18, is designed with an ‘encryption-first’ approach, ensuring that utilities like sqlcmd and bcp that utilize the Microsoft ODBC driver will operate under the ‘secure by default’ principle. Users who wish to disable encryption will need to do so explicitly.

So, the fix is to add "-No". Also, improved the HEALTHCHECK a bit.

@shmsr shmsr added the Integration:sql_input SQL Input label Aug 28, 2024
@shmsr shmsr changed the title packages/microsoft_sqlserver: Fix HEALTHCHECK packages/{microsoft_sqlserver,sql_input}: Fix HEALTHCHECK Aug 28, 2024
@shmsr shmsr changed the title packages/{microsoft_sqlserver,sql_input}: Fix HEALTHCHECK packages/microsoft_sqlserver: Fix HEALTHCHECK Aug 28, 2024
@shmsr shmsr removed the Integration:sql_input SQL Input label Aug 28, 2024
@elasticmachine
Copy link

elasticmachine commented Aug 28, 2024

💚 Build Succeeded

History

cc @shmsr

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 28, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@shmsr shmsr mentioned this pull request Aug 30, 2024
Merged
4 tasks
agithomas
agithomas approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmsr shmsr merged commit e768290 into elastic:main Aug 30, 2024
@shmsr shmsr deleted the microsoft_sqlserver_fix_ci_bin branch September 1, 2024 17:13
This was referenced Oct 3, 2024
Merged
Merged
This was referenced Oct 4, 2024
Merged
Merged
Merged
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@shmsr
packages/microsoft_sqlserver: Fix HEALTHCHECK (elastic#10899)
cf386be
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@shmsr
packages/microsoft_sqlserver: Fix HEALTHCHECK (elastic#10899)
3e95c54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@anil-elastic anil-elastic anil-elastic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@shmsr shmsr

Labels

bugfix Pull request that fixes a bug issue Integration:microsoft_sqlserver Microsoft SQL Server Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[microsoft_sqlserver] Failing test daily: system test: errorlog in microsoft_sqlserver.log

5 participants

@shmsr @elasticmachine @agithomas @anil-elastic @andrewkroh